Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: src/objects-inl.h

Issue 2554343002: [runtime] Add instance size check for CheckEquivalent(). (Closed)
Patch Set: Fix the header size calculation for modules. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/wasm/add-getters.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 2090 matching lines...) Expand 10 before | Expand all | Expand 10 after
2101 case JS_MESSAGE_OBJECT_TYPE: 2101 case JS_MESSAGE_OBJECT_TYPE:
2102 return JSMessageObject::kSize; 2102 return JSMessageObject::kSize;
2103 case JS_ARGUMENTS_TYPE: 2103 case JS_ARGUMENTS_TYPE:
2104 return JSArgumentsObject::kHeaderSize; 2104 return JSArgumentsObject::kHeaderSize;
2105 case JS_ERROR_TYPE: 2105 case JS_ERROR_TYPE:
2106 return JSObject::kHeaderSize; 2106 return JSObject::kHeaderSize;
2107 case JS_STRING_ITERATOR_TYPE: 2107 case JS_STRING_ITERATOR_TYPE:
2108 return JSStringIterator::kSize; 2108 return JSStringIterator::kSize;
2109 case JS_FIXED_ARRAY_ITERATOR_TYPE: 2109 case JS_FIXED_ARRAY_ITERATOR_TYPE:
2110 return JSFixedArrayIterator::kHeaderSize; 2110 return JSFixedArrayIterator::kHeaderSize;
2111 case JS_MODULE_NAMESPACE_TYPE:
2112 return JSModuleNamespace::kSize;
2111 default: 2113 default:
2112 UNREACHABLE(); 2114 UNREACHABLE();
2113 return 0; 2115 return 0;
2114 } 2116 }
2115 } 2117 }
2116 2118
2117 2119
2118 int JSObject::GetInternalFieldCount(Map* map) { 2120 int JSObject::GetInternalFieldCount(Map* map) {
2119 int instance_size = map->instance_size(); 2121 int instance_size = map->instance_size();
2120 if (instance_size == kVariableSizeSentinel) return 0; 2122 if (instance_size == kVariableSizeSentinel) return 0;
(...skipping 6345 matching lines...) Expand 10 before | Expand all | Expand 10 after
8466 #undef WRITE_INT64_FIELD 8468 #undef WRITE_INT64_FIELD
8467 #undef READ_BYTE_FIELD 8469 #undef READ_BYTE_FIELD
8468 #undef WRITE_BYTE_FIELD 8470 #undef WRITE_BYTE_FIELD
8469 #undef NOBARRIER_READ_BYTE_FIELD 8471 #undef NOBARRIER_READ_BYTE_FIELD
8470 #undef NOBARRIER_WRITE_BYTE_FIELD 8472 #undef NOBARRIER_WRITE_BYTE_FIELD
8471 8473
8472 } // namespace internal 8474 } // namespace internal
8473 } // namespace v8 8475 } // namespace v8
8474 8476
8475 #endif // V8_OBJECTS_INL_H_ 8477 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/wasm/add-getters.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698