Make ifdefs consistent in WebKit/Source/core/layout/ .

Make ifdefs consistent in WebKit/Source/core/layout/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/509b031245c26901d8536aff3c6f207469142101
Cr-Commit-Position: refs/heads/master@{#436725}

[Alexander Alekseev, 2016-12-06 09:45:30]

Description was changed from

==========
Make ifdefs consistent in WebKit/Source/core/layout/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
==========

to

==========
Make ifdefs consistent in WebKit/Source/core/layout/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Alexander Alekseev, 2016-12-06 09:48:05]

alemate@chromium.org changed reviewers:
+ mstensho@opera.com

[Alexander Alekseev, 2016-12-06 09:48:06]

Please review.

[Alexander Alekseev, 2016-12-06 09:48:19]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 09:48:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mstensho (USE GERRIT), 2016-12-06 09:58:46]

https://codereview.chromium.org/2553653003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2553653003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:790:
ASSERT(!object->isSetNeedsLayoutForbidden());
DCHECK.

Looks like this would look prettier if you replace the three DCHECKs with one
DCHECK after the if-else blocks, since they all perform this.

https://codereview.chromium.org/2553653003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.h (right):

https://codereview.chromium.org/2553653003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.h:2567:
ASSERT(!isSetNeedsLayoutForbidden());
DCHECK

[Alexander Alekseev, 2016-12-06 10:13:30]

https://codereview.chromium.org/2553653003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2553653003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:790:
ASSERT(!object->isSetNeedsLayoutForbidden());
On 2016/12/06 09:58:46, mstensho wrote:
> DCHECK.
> 
> Looks like this would look prettier if you replace the three DCHECKs with one
> DCHECK after the if-else blocks, since they all perform this.

Done.

https://codereview.chromium.org/2553653003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.h (right):

https://codereview.chromium.org/2553653003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.h:2567:
ASSERT(!isSetNeedsLayoutForbidden());
On 2016/12/06 09:58:46, mstensho wrote:
> DCHECK

Done.

[Alexander Alekseev, 2016-12-06 10:13:36]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 10:13:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mstensho (USE GERRIT), 2016-12-06 10:24:59]

lgtm

[commit-bot: I haz the power, 2016-12-06 11:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 11:52:12]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-12-06 21:01:39]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-12-06 21:02:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 21:14:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481058099325250,
"parent_rev": "90d42e356165331c4bb1e79cdcd4ea78f0c8faa9", "commit_rev":
"203ec9093b6648e5665a9497f8de7f2409977fd5"}

[commit-bot: I haz the power, 2016-12-06 21:15:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-06 21:19:09]

Description was changed from

==========
Make ifdefs consistent in WebKit/Source/core/layout/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Make ifdefs consistent in WebKit/Source/core/layout/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/509b031245c26901d8536aff3c6f207469142101
Cr-Commit-Position: refs/heads/master@{#436725}
==========

[commit-bot: I haz the power, 2016-12-06 21:19:10]

Patchset 3 (id:??) landed as
https://crrev.com/509b031245c26901d8536aff3c6f207469142101
Cr-Commit-Position: refs/heads/master@{#436725}