third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2553653003: Make ifdefs consistent in WebKit/Source/core/layout/ .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2553653003: Make ifdefs consistent in WebKit/Source/core/layout/ . (Closed)

Patch Set: Update after review. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index fc48cab3e05c766569f25454af712a7460b27e11..72d1155b59294cb56a1bf1343ca60a6f9ed6c1b0 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -1159,7 +1159,7 @@ void LayoutBox::computeIntrinsicLogicalWidths(

LayoutUnit LayoutBox::minPreferredLogicalWidth() const {

if (preferredLogicalWidthsDirty()) {

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

SetLayoutNeededForbiddenScope layoutForbiddenScope(

const_cast<LayoutBox&>(*this));

#endif

@@ -1173,7 +1173,7 @@ LayoutUnit LayoutBox::minPreferredLogicalWidth() const {

DISABLE_CFI_PERF