third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp - Issue 2553653003: Make ifdefs consistent in WebKit/Source/core/layout/ .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp

Issue 2553653003: Make ifdefs consistent in WebKit/Source/core/layout/ . (Closed)

Patch Set: Update after review. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp

diff --git a/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp b/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp

index 1d6bd572f03bad9d320ae435cc6a877f0655f32d..212ac74eec7b26823d289c5a2e430f8cfcf13aec 100644

--- a/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp

+++ b/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp

@@ -42,7 +42,7 @@ SubtreeLayoutScope::SubtreeLayoutScope(LayoutObject& root) : m_root(root) {

SubtreeLayoutScope::~SubtreeLayoutScope() {

RELEASE_ASSERT(!m_root.needsLayout());

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

for (auto* layoutObject : m_layoutObjectsToLayout)

layoutObject->assertLaidOut();

#endif

@@ -62,7 +62,7 @@ void SubtreeLayoutScope::setChildNeedsLayout(LayoutObject* descendant) {

void SubtreeLayoutScope::recordObjectMarkedForLayout(

LayoutObject* layoutObject) {

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

m_layoutObjectsToLayout.add(layoutObject);

#endif

}