[test] Only run presubmit for changed status files

[test] Only run presubmit for changed status files

This turns the status files check into a source processor similar to
lint and copyright check. On upload and on trybots it will only run
on the affected files.

BUG=v8:5603
NOTRY=true

Committed: https://crrev.com/dd0202a78673677f73edee1c0dfe828023464c94
Cr-Commit-Position: refs/heads/master@{#41516}

[Michael Achenbach, 2016-12-05 13:25:44]

Description was changed from

==========
[test] Only run presubmit for changed status files

BUG=
==========

to

==========
[test] Only run presubmit for changed status files

This turns the status files check into a source processor similar to
lint and copyright check. On upload and on trybots it will only run
on the affected files.

BUG=v8:5603
NOTRY=true
==========

[Michael Achenbach, 2016-12-05 13:25:45]

machenbach@chromium.org changed reviewers:
+ jkummerow@chromium.org, jochen@chromium.org

[Michael Achenbach, 2016-12-05 13:27:07]

PTAL

[jochen (gone - plz use gerrit), 2016-12-05 13:28:06]

lgtm

[Michael Achenbach, 2016-12-06 11:35:37]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-12-06 11:35:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 11:37:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 11:37:58]

Failed to apply patch for PRESUBMIT.py:
While running git apply --index -p1;
  error: patch failed: PRESUBMIT.py:78
  error: PRESUBMIT.py: patch does not apply

Patch:       PRESUBMIT.py
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index
85dbdcda6fbd39b11c78b1845ed77602dc53da82..313b94d00b3a1338b49663cbdd8ecdf11dcbf6cf
100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -67,7 +67,7 @@ def _V8PresubmitChecks(input_api, output_api):
         input_api.PresubmitLocalPath(), 'tools'))
   from presubmit import CppLintProcessor
   from presubmit import SourceProcessor
-  from presubmit import CheckStatusFiles
+  from presubmit import StatusFilesProcessor
 
   results = []
   if not CppLintProcessor().RunOnFiles(
@@ -78,7 +78,8 @@ def _V8PresubmitChecks(input_api, output_api):
     results.append(output_api.PresubmitError(
         "Copyright header, trailing whitespaces and two empty lines " \
         "between declarations check failed"))
-  if not CheckStatusFiles(input_api.PresubmitLocalPath()):
+  if not StatusFilesProcessor().RunOnFiles(
+      input_api.AffectedFiles(include_deletes=False)):
     results.append(output_api.PresubmitError("Status file check failed"))
   results.extend(_CheckAuthorizedAuthor(input_api, output_api))
   return results

[Michael Achenbach, 2016-12-06 11:39:33]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-12-06 11:39:33]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2553633002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-06 11:39:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 11:41:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481024373314770,
"parent_rev": "dc6f7b770623c1d991d8dea2af9174c0ef3e2ca9", "commit_rev":
"9e447193de8fa4e9c70daea368d1634979d1a9ef"}

[commit-bot: I haz the power, 2016-12-06 11:41:39]

Description was changed from

==========
[test] Only run presubmit for changed status files

This turns the status files check into a source processor similar to
lint and copyright check. On upload and on trybots it will only run
on the affected files.

BUG=v8:5603
NOTRY=true
==========

to

==========
[test] Only run presubmit for changed status files

This turns the status files check into a source processor similar to
lint and copyright check. On upload and on trybots it will only run
on the affected files.

BUG=v8:5603
NOTRY=true
==========

[commit-bot: I haz the power, 2016-12-06 11:41:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-06 11:42:23]

Description was changed from

==========
[test] Only run presubmit for changed status files

This turns the status files check into a source processor similar to
lint and copyright check. On upload and on trybots it will only run
on the affected files.

BUG=v8:5603
NOTRY=true
==========

to

==========
[test] Only run presubmit for changed status files

This turns the status files check into a source processor similar to
lint and copyright check. On upload and on trybots it will only run
on the affected files.

BUG=v8:5603
NOTRY=true

Committed: https://crrev.com/dd0202a78673677f73edee1c0dfe828023464c94
Cr-Commit-Position: refs/heads/master@{#41516}
==========

[commit-bot: I haz the power, 2016-12-06 11:42:24]

Patchset 2 (id:??) landed as
https://crrev.com/dd0202a78673677f73edee1c0dfe828023464c94
Cr-Commit-Position: refs/heads/master@{#41516}