OLD | NEW |
1 # Copyright 2012 the V8 project authors. All rights reserved. | 1 # Copyright 2012 the V8 project authors. All rights reserved. |
2 # Redistribution and use in source and binary forms, with or without | 2 # Redistribution and use in source and binary forms, with or without |
3 # modification, are permitted provided that the following conditions are | 3 # modification, are permitted provided that the following conditions are |
4 # met: | 4 # met: |
5 # | 5 # |
6 # * Redistributions of source code must retain the above copyright | 6 # * Redistributions of source code must retain the above copyright |
7 # notice, this list of conditions and the following disclaimer. | 7 # notice, this list of conditions and the following disclaimer. |
8 # * Redistributions in binary form must reproduce the above | 8 # * Redistributions in binary form must reproduce the above |
9 # copyright notice, this list of conditions and the following | 9 # copyright notice, this list of conditions and the following |
10 # disclaimer in the documentation and/or other materials provided | 10 # disclaimer in the documentation and/or other materials provided |
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
60 'not perfect. The commit queue will not block on this warning.') | 60 'not perfect. The commit queue will not block on this warning.') |
61 | 61 |
62 | 62 |
63 def _V8PresubmitChecks(input_api, output_api): | 63 def _V8PresubmitChecks(input_api, output_api): |
64 """Runs the V8 presubmit checks.""" | 64 """Runs the V8 presubmit checks.""" |
65 import sys | 65 import sys |
66 sys.path.append(input_api.os_path.join( | 66 sys.path.append(input_api.os_path.join( |
67 input_api.PresubmitLocalPath(), 'tools')) | 67 input_api.PresubmitLocalPath(), 'tools')) |
68 from presubmit import CppLintProcessor | 68 from presubmit import CppLintProcessor |
69 from presubmit import SourceProcessor | 69 from presubmit import SourceProcessor |
70 from presubmit import CheckStatusFiles | 70 from presubmit import StatusFilesProcessor |
71 | 71 |
72 results = [] | 72 results = [] |
73 if not CppLintProcessor().RunOnFiles( | 73 if not CppLintProcessor().RunOnFiles( |
74 input_api.AffectedFiles(include_deletes=False)): | 74 input_api.AffectedFiles(include_deletes=False)): |
75 results.append(output_api.PresubmitError("C++ lint check failed")) | 75 results.append(output_api.PresubmitError("C++ lint check failed")) |
76 if not SourceProcessor().RunOnFiles( | 76 if not SourceProcessor().RunOnFiles( |
77 input_api.AffectedFiles(include_deletes=False)): | 77 input_api.AffectedFiles(include_deletes=False)): |
78 results.append(output_api.PresubmitError( | 78 results.append(output_api.PresubmitError( |
79 "Copyright header, trailing whitespaces and two empty lines " \ | 79 "Copyright header, trailing whitespaces and two empty lines " \ |
80 "between declarations check failed")) | 80 "between declarations check failed")) |
81 if not CheckStatusFiles(input_api.PresubmitLocalPath()): | 81 if not StatusFilesProcessor().RunOnFiles( |
| 82 input_api.AffectedFiles(include_deletes=False)): |
82 results.append(output_api.PresubmitError("Status file check failed")) | 83 results.append(output_api.PresubmitError("Status file check failed")) |
83 results.extend(input_api.canned_checks.CheckAuthorizedAuthor( | 84 results.extend(input_api.canned_checks.CheckAuthorizedAuthor( |
84 input_api, output_api)) | 85 input_api, output_api)) |
85 return results | 86 return results |
86 | 87 |
87 | 88 |
88 def _CheckUnwantedDependencies(input_api, output_api): | 89 def _CheckUnwantedDependencies(input_api, output_api): |
89 """Runs checkdeps on #include statements added in this | 90 """Runs checkdeps on #include statements added in this |
90 change. Breaking - rules is an error, breaking ! rules is a | 91 change. Breaking - rules is an error, breaking ! rules is a |
91 warning. | 92 warning. |
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
284 def CheckChangeOnCommit(input_api, output_api): | 285 def CheckChangeOnCommit(input_api, output_api): |
285 results = [] | 286 results = [] |
286 results.extend(_CommonChecks(input_api, output_api)) | 287 results.extend(_CommonChecks(input_api, output_api)) |
287 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 288 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
288 input_api, output_api)) | 289 input_api, output_api)) |
289 if not _SkipTreeCheck(input_api, output_api): | 290 if not _SkipTreeCheck(input_api, output_api): |
290 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 291 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
291 input_api, output_api, | 292 input_api, output_api, |
292 json_url='http://v8-status.appspot.com/current?format=json')) | 293 json_url='http://v8-status.appspot.com/current?format=json')) |
293 return results | 294 return results |
OLD | NEW |