[test] Refactoring - move presubmit method

[test] Refactoring - move presubmit method

Move a method that is not referenced in tools/presubmit.py.

BUG=v8:5603
NOTRY=true

Committed: https://crrev.com/d50108adc8e2cd8be51378b1523c857fd41c96c9
Cr-Commit-Position: refs/heads/master@{#41513}

[Michael Achenbach, 2016-12-05 13:02:33]

Description was changed from

==========
[test] Refactoring - move presubmit method

BUG=
==========

to

==========
[test] Refactoring - move presubmit method

BUG=v8:5603
NOTRY=true
==========

[Michael Achenbach, 2016-12-05 13:02:33]

machenbach@chromium.org changed reviewers:
+ jkummerow@chromium.org, jochen@chromium.org

[Michael Achenbach, 2016-12-05 13:05:28]

Description was changed from

==========
[test] Refactoring - move presubmit method

BUG=v8:5603
NOTRY=true
==========

to

==========
[test] Refactoring - move presubmit method

Move a method that is not referenced in tools/presubmit.py.

BUG=v8:5603
NOTRY=true
==========

[Michael Achenbach, 2016-12-05 13:05:35]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 13:05:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-12-05 13:05:42]

PTAL

[commit-bot: I haz the power, 2016-12-05 13:07:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 13:07:11]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-12-05 13:13:57]

what about moving the code to depot_tools/presubmit_canned_checks - it seems
like a copy of the chromium PRESUBMIT check

[Michael Achenbach, 2016-12-05 13:39:24]

On 2016/12/05 13:13:57, jochen wrote:
> what about moving the code to depot_tools/presubmit_canned_checks - it seems
> like a copy of the chromium PRESUBMIT check

https://chromium-review.googlesource.com/c/416859/

Will update this once it has landed.

[jochen (gone - plz use gerrit), 2016-12-05 15:22:01]

lgtm once the depot_tools roll is in

[Michael Achenbach, 2016-12-06 11:28:46]

On 2016/12/05 15:22:01, jochen wrote:
> lgtm once the depot_tools roll is in

Updated CL. Depot_tools rolled here: https://codereview.chromium.org/2551923002

[Michael Achenbach, 2016-12-06 11:29:26]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-12-06 11:29:26]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2553623002/#ps40001
(title: "Use method from canned_checks")

[commit-bot: I haz the power, 2016-12-06 11:29:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 11:31:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481023766414310,
"parent_rev": "f492389d26df26161f309e7e486b646c952bc1a2", "commit_rev":
"e418de80bcc067b73de6306c60b96b61923c2ade"}

[commit-bot: I haz the power, 2016-12-06 11:31:16]

Description was changed from

==========
[test] Refactoring - move presubmit method

Move a method that is not referenced in tools/presubmit.py.

BUG=v8:5603
NOTRY=true
==========

to

==========
[test] Refactoring - move presubmit method

Move a method that is not referenced in tools/presubmit.py.

BUG=v8:5603
NOTRY=true
==========

[commit-bot: I haz the power, 2016-12-06 11:31:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-06 11:31:38]

Description was changed from

==========
[test] Refactoring - move presubmit method

Move a method that is not referenced in tools/presubmit.py.

BUG=v8:5603
NOTRY=true
==========

to

==========
[test] Refactoring - move presubmit method

Move a method that is not referenced in tools/presubmit.py.

BUG=v8:5603
NOTRY=true

Committed: https://crrev.com/d50108adc8e2cd8be51378b1523c857fd41c96c9
Cr-Commit-Position: refs/heads/master@{#41513}
==========

[commit-bot: I haz the power, 2016-12-06 11:31:39]

Patchset 3 (id:??) landed as
https://crrev.com/d50108adc8e2cd8be51378b1523c857fd41c96c9
Cr-Commit-Position: refs/heads/master@{#41513}