Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 2553013004: Remove the app banner navigation heuristic. (Closed)
Patch Set: Add comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.h
diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h
index 20bff4cce5498300ed8d62446cfa00b5ceac347c..15bb380e82d3f31cb699af498d128748e08402fb 100644
--- a/chrome/browser/banners/app_banner_manager.h
+++ b/chrome/browser/banners/app_banner_manager.h
@@ -58,11 +58,8 @@ class AppBannerManager : public content::WebContentsObserver,
// Fast-forwards the current time for testing.
static void SetTimeDeltaForTesting(int days);
- // Sets the weights applied to direct and indirect navigations for triggering
- // the banner. Deprecated and will be removed when app banners fully migrates
- // to using site engagement as a trigger.
- static void SetEngagementWeights(double direct_engagement,
- double indirect_engagement);
+ // Sets the total engagement required for triggering the banner in testing.
+ static void SetTotalEngagementToTrigger(double engagement);
// Returns whether or not the URLs match for everything except for the ref.
static bool URLsAreForTheSamePage(const GURL& first, const GURL& second);
@@ -160,9 +157,8 @@ class AppBannerManager : public content::WebContentsObserver,
// Sends a message to the renderer that the page has met the requirements to
// show a banner. The page can respond to cancel the banner (and possibly
- // display it later), or otherwise allow it to be shown. This is virtual to
- // allow tests to mock out the renderer IPC.
- virtual void SendBannerPromptRequest();
+ // display it later), or otherwise allow it to be shown.
+ void SendBannerPromptRequest();
// content::WebContentsObserver overrides.
void DidStartNavigation(content::NavigationHandle* handle) override;
@@ -233,9 +229,6 @@ class AppBannerManager : public content::WebContentsObserver,
// requesting that it be shown later.
void DisplayAppBanner() override;
- // The type of navigation made to the page
- ui::PageTransition last_transition_type_;
-
// Fetches the data required to display a banner for the current page.
InstallableManager* manager_;
« no previous file with comments | « chrome/browser/android/banners/app_banner_manager_android.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698