Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2553013004: Remove the app banner navigation heuristic. (Closed)
Patch Set: Add comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index 11e2df9a1c854a1d6425f0f0ff64ad82ef345a84..38358bc07d054585dc1d98bbe7519493dca113bc 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -307,12 +307,12 @@ ScopedJavaLocalRef<jobject> GetJavaBannerManagerForWebContents(
}
// static
-void SetEngagementWeights(JNIEnv* env,
- const JavaParamRef<jclass>& clazz,
- jdouble direct_engagement,
- jdouble indirect_engagement) {
- AppBannerManager::SetEngagementWeights(direct_engagement,
- indirect_engagement);
+void SetDaysAfterDismissAndIgnoreToTrigger(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ jint dismiss_days,
+ jint ignore_days) {
+ AppBannerSettingsHelper::SetDaysAfterDismissAndIgnoreToTrigger(dismiss_days,
+ ignore_days);
}
// static
@@ -322,4 +322,11 @@ void SetTimeDeltaForTesting(JNIEnv* env,
AppBannerManager::SetTimeDeltaForTesting(days);
}
+// static
+void SetTotalEngagementToTrigger(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ jdouble engagement) {
+ AppBannerSettingsHelper::SetTotalEngagementToTrigger(engagement);
+}
+
} // namespace banners

Powered by Google App Engine
This is Rietveld 408576698