Remove the app banner navigation heuristic.

chrome/browser/banners/app_banner_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
 #define CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 40 matching lines @@
 class AppBannerManager : public content::WebContentsObserver,
                          public blink::mojom::AppBannerService,
                          public SiteEngagementObserver {
  public:
   // Returns the current time.
   static base::Time GetCurrentTime();
 
   // Fast-forwards the current time for testing.
   static void SetTimeDeltaForTesting(int days);
 
-  // Sets the weights applied to direct and indirect navigations for triggering
-  // the banner. Deprecated and will be removed when app banners fully migrates
-  // to using site engagement as a trigger.
-  static void SetEngagementWeights(double direct_engagement,
-                                   double indirect_engagement);
+  // Sets the total engagement required for triggering the banner in testing.
+  static void SetTotalEngagementToTrigger(double engagement);
 
   // Returns whether or not the URLs match for everything except for the ref.
   static bool URLsAreForTheSamePage(const GURL& first, const GURL& second);
 
   // Requests an app banner. If |is_debug_mode| is true, any failure in the
   // pipeline will be reported to the devtools console.
   virtual void RequestAppBanner(const GURL& validated_url, bool is_debug_mode);
 
   // Sends a message to the renderer that the user accepted the banner. Does
   // nothing if |request_id| does not match the current request.
@@ skipping 77 matching lines @@
   void ReportStatus(content::WebContents* web_contents,
                     InstallableStatusCode code);
 
   // Stops the banner pipeline, preventing any outstanding callbacks from
   // running and resetting the manager state. This method is virtual to allow
   // tests to intercept it and verify correct behaviour.
   virtual void Stop();
 
   // Sends a message to the renderer that the page has met the requirements to
   // show a banner. The page can respond to cancel the banner (and possibly
-  // display it later), or otherwise allow it to be shown. This is virtual to
-  // allow tests to mock out the renderer IPC.
-  virtual void SendBannerPromptRequest();
+  // display it later), or otherwise allow it to be shown.
+  void SendBannerPromptRequest();
 
   // content::WebContentsObserver overrides.
   void DidStartNavigation(content::NavigationHandle* handle) override;
   void DidFinishNavigation(content::NavigationHandle* handle) override;
   void DidFinishLoad(content::RenderFrameHost* render_frame_host,
                      const GURL& validated_url) override;
   void MediaStartedPlaying(const MediaPlayerInfo& media_info,
                            const MediaPlayerId& id) override;
   void MediaStoppedPlaying(const MediaPlayerInfo& media_info,
                            const MediaPlayerId& id) override;
@@ skipping 50 matching lines @@
   // intention to show a prompt. The renderer will send a message back with the
   // opportunity to cancel.
   void OnBannerPromptReply(blink::mojom::AppBannerPromptReply reply,
                            const std::string& referrer);
 
   // blink::mojom::AppBannerService overrides.
   // Called when Blink has prevented a banner from being shown, and is now
   // requesting that it be shown later.
   void DisplayAppBanner() override;
 
-  // The type of navigation made to the page
-  ui::PageTransition last_transition_type_;
-
   // Fetches the data required to display a banner for the current page.
   InstallableManager* manager_;
 
   // A monotonically increasing id to verify the response to the
   // beforeinstallprompt event from the renderer.
   int event_request_id_;
 
   // We do not want to trigger a banner when the manager is attached to
   // a WebContents that is playing video. Banners triggering on a site in the
   // background will appear when the tab is reactivated.
@@ skipping 27 matching lines @@
   // scoped to the WebContents which they are observing. This allows us to use
   // weak pointers for callbacks.
   base::WeakPtrFactory<AppBannerManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AppBannerManager);
 };
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_