Files app: Show a dialog to suggest extensions when file's extension or mime type is available.

Files app: Show a dialog to suggest extensions when file's extension or mime type is available.

Before, when the mime type is not obtained from files, we didn't show 
suggest app dialog for the files even when we can guess the file 
types by file extensions.
By this change, we show the suggest app dialog when we have either non-empty file extension or mime type.

BUG=671585
TEST=download tgz file, and confirm that double-clicking the tgz file shows suggestions about extensions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2553003003
Cr-Commit-Position: refs/heads/master@{#442858}
Committed: https://chromium.googlesource.com/chromium/src/+/f99c4fce53c83466a05a445007d108a451dc4ba6

[fukino, 2016-12-06 13:10:42]

Description was changed from

==========
Files app: Show a dialog to suggest extensions when file's extension or mime
type is available.

BUG=671585
TEST=download tgz file, and confirm that double-clicking the tgz file shows
suggestions about extensions.
==========

to

==========
Files app: Show a dialog to suggest extensions when file's extension or mime
type is available.

BUG=671585
TEST=download tgz file, and confirm that double-clicking the tgz file shows
suggestions about extensions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-06 13:11:05]

fukino@chromium.org changed reviewers:
+ yamaguchi@chromium.org

[yamaguchi, 2016-12-07 01:56:09]

lgtm

[fukino, 2016-12-07 03:25:49]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2016-12-07 03:26:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 03:38:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 03:38:25]

Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[fukino, 2017-01-11 09:46:39]

yamaguchi@,

I edited suggest_app_dialog.js to make the mime type optional.
We should open suggest app dialog only when we have file extensions.
Could you take another look?

[yamaguchi, 2017-01-11 09:52:45]

On 2017/01/11 09:46:39, fukino wrote:
> yamaguchi@,
> 
> I edited suggest_app_dialog.js to make the mime type optional.
> We should open suggest app dialog only when we have file extensions.
> Could you take another look?

lgtm

[fukino, 2017-01-11 10:03:31]

On 2017/01/11 09:52:45, yamaguchi wrote:
> On 2017/01/11 09:46:39, fukino wrote:
> > yamaguchi@,
> > 
> > I edited suggest_app_dialog.js to make the mime type optional.
> > We should open suggest app dialog only when we have file extensions.
> > Could you take another look?
> 
> lgtm

Thank you for the quick review!

[fukino, 2017-01-11 10:03:36]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2017-01-11 10:04:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 10:32:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484129016018890,
"parent_rev": "7e9f15b31cf27e8ebc5694dd417d15723c883367", "commit_rev":
"f99c4fce53c83466a05a445007d108a451dc4ba6"}

[commit-bot: I haz the power, 2017-01-11 10:33:26]

Description was changed from

==========
Files app: Show a dialog to suggest extensions when file's extension or mime
type is available.

BUG=671585
TEST=download tgz file, and confirm that double-clicking the tgz file shows
suggestions about extensions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Show a dialog to suggest extensions when file's extension or mime
type is available.

BUG=671585
TEST=download tgz file, and confirm that double-clicking the tgz file shows
suggestions about extensions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2553003003
Cr-Commit-Position: refs/heads/master@{#442858}
Committed:
https://chromium.googlesource.com/chromium/src/+/f99c4fce53c83466a05a445007d1...
==========

[commit-bot: I haz the power, 2017-01-11 10:33:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f99c4fce53c83466a05a445007d1...

[oka, 2017-01-11 10:33:49]

On 2017/01/11 10:04:07, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Just drove by, but could you explain what was changed with this CL to fix the
problem in the description?

[oka, 2017-01-11 10:33:52]

On 2017/01/11 10:04:07, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Just drove by, but could you explain what was changed with this CL to fix the
problem in the description?

[oka, 2017-01-11 10:34:07]

On 2017/01/11 10:33:52, oka wrote:
> On 2017/01/11 10:04:07, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> Just drove by, but could you explain what was changed with this CL to fix the
> problem in the description?

Oh too late.

[fukino, 2017-01-11 10:55:08]

Description was changed from

==========
Files app: Show a dialog to suggest extensions when file's extension or mime
type is available.

BUG=671585
TEST=download tgz file, and confirm that double-clicking the tgz file shows
suggestions about extensions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2553003003
Cr-Commit-Position: refs/heads/master@{#442858}
Committed:
https://chromium.googlesource.com/chromium/src/+/f99c4fce53c83466a05a445007d1...
==========

to

==========
Files app: Show a dialog to suggest extensions when file's extension or mime
type is available.

Before, when the mime type is not obtained from files, we didn't show 
suggest app dialog for the files even when we can guess the file 
types by file extensions.
By this change, we show the suggest app dialog when we have either non-empty
file extension or mime type.

BUG=671585
TEST=download tgz file, and confirm that double-clicking the tgz file shows
suggestions about extensions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2553003003
Cr-Commit-Position: refs/heads/master@{#442858}
Committed:
https://chromium.googlesource.com/chromium/src/+/f99c4fce53c83466a05a445007d1...
==========

[fukino, 2017-01-11 10:55:27]

Updated the bug description.