Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: ui/file_manager/file_manager/foreground/js/file_tasks.js

Issue 2553003003: Files app: Show a dialog to suggest extensions when file's extension or mime type is available. (Closed)
Patch Set: Make the mime type of suggestAppDialog opational. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/file_tasks.js
diff --git a/ui/file_manager/file_manager/foreground/js/file_tasks.js b/ui/file_manager/file_manager/foreground/js/file_tasks.js
index 6ba5710b53e7eec805af716458510117bae8fb81..1eda2d859faf57f42982b765cae94f971f729a22 100644
--- a/ui/file_manager/file_manager/foreground/js/file_tasks.js
+++ b/ui/file_manager/file_manager/foreground/js/file_tasks.js
@@ -206,7 +206,7 @@ FileTasks.prototype.openSuggestAppsDialog = function(
var extension = splitted[1];
// Returns with failure if the file has neither extension nor MIME type.
- if (!extension || !mimeType) {
+ if (!extension && !mimeType) {
onFailure();
return;
}
« no previous file with comments | « no previous file | ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698