Signin: prevent stale dialogs from appearing.

Signin: prevent stale dialogs from appearing.

If GMS needs to be updated when fetching accounts and the user switches
between Chrome and another app during the update, the GMS update dialog
in Chrome will persist after the update is complete.

Now, the dialog is dismissed when the view becomes invisible so that no
GMS update dialog is shown when switching back to Chrome after a
completed GMS update.

BUG=669522
Committed: https://crrev.com/7c3dfc3ec428d81be2f2bf8c1af5f483c183aaf2
Cr-Commit-Position: refs/heads/master@{#439178}

[estevenson, 2016-12-05 23:51:14]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 23:51:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estevenson, 2016-12-05 23:55:08]

estevenson@chromium.org changed reviewers:
+ bauerb@chromium.org

[estevenson, 2016-12-05 23:55:09]

ptal bauerb!

I couldn't think of a cleaner way to manage this since we don't create the
dialog ourselves, wdyt?

[commit-bot: I haz the power, 2016-12-06 01:12:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 01:12:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Bernhard Bauer, 2016-12-06 17:10:58]

lgtm

https://codereview.chromium.org/2552893002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
(right):

https://codereview.chromium.org/2552893002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java:200:
updateAccounts();
I would maybe return here and then leave out the else in the next if.

[estevenson, 2016-12-06 23:53:33]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 23:54:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estevenson, 2016-12-06 23:56:29]

Thanks for the reviews!

https://codereview.chromium.org/2552893002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
(right):

https://codereview.chromium.org/2552893002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java:200:
updateAccounts();
On 2016/12/06 17:10:58, Bernhard Bauer wrote:
> I would maybe return here and then leave out the else in the next if.

Done.

[estevenson, 2016-12-16 16:21:44]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2016-12-16 16:21:45]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2552893002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-16 16:22:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 18:07:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 18:07:29]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[estevenson, 2016-12-16 18:21:32]

The CQ bit was checked by estevenson@chromium.org

[commit-bot: I haz the power, 2016-12-16 18:22:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 20:47:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481912492551420,
"parent_rev": "c109efc2ab14394d7643fc9a6713e1935ee6d201", "commit_rev":
"ff4ffbddd5eb4a897346a70116566e3807b31b26"}

[commit-bot: I haz the power, 2016-12-16 20:47:45]

Description was changed from

==========
Signin: prevent stale dialogs from appearing.

If GMS needs to be updated when fetching accounts and the user switches
between Chrome and another app during the update, the GMS update dialog
in Chrome will persist after the update is complete.

Now, the dialog is dismissed when the view becomes invisible so that no
GMS update dialog is shown when switching back to Chrome after a
completed GMS update.

BUG=669522
==========

to

==========
Signin: prevent stale dialogs from appearing.

If GMS needs to be updated when fetching accounts and the user switches
between Chrome and another app during the update, the GMS update dialog
in Chrome will persist after the update is complete.

Now, the dialog is dismissed when the view becomes invisible so that no
GMS update dialog is shown when switching back to Chrome after a
completed GMS update.

BUG=669522

Review-Url: https://codereview.chromium.org/2552893002
==========

[commit-bot: I haz the power, 2016-12-16 20:47:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-16 20:51:28]

Description was changed from

==========
Signin: prevent stale dialogs from appearing.

If GMS needs to be updated when fetching accounts and the user switches
between Chrome and another app during the update, the GMS update dialog
in Chrome will persist after the update is complete.

Now, the dialog is dismissed when the view becomes invisible so that no
GMS update dialog is shown when switching back to Chrome after a
completed GMS update.

BUG=669522

Review-Url: https://codereview.chromium.org/2552893002
==========

to

==========
Signin: prevent stale dialogs from appearing.

If GMS needs to be updated when fetching accounts and the user switches
between Chrome and another app during the update, the GMS update dialog
in Chrome will persist after the update is complete.

Now, the dialog is dismissed when the view becomes invisible so that no
GMS update dialog is shown when switching back to Chrome after a
completed GMS update.

BUG=669522

Committed: https://crrev.com/7c3dfc3ec428d81be2f2bf8c1af5f483c183aaf2
Cr-Commit-Position: refs/heads/master@{#439178}
==========

[commit-bot: I haz the power, 2016-12-16 20:51:29]

Patchset 4 (id:??) landed as
https://crrev.com/7c3dfc3ec428d81be2f2bf8c1af5f483c183aaf2
Cr-Commit-Position: refs/heads/master@{#439178}