Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java

Issue 2552893002: Signin: prevent stale dialogs from appearing. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java
index 7461ca172d5c5af46d401439d6acf7d91a4ff875..ba1c4ceb6b8b188de3546066e0dba9693bd63fc0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java
@@ -127,6 +127,8 @@ public abstract class UserRecoverableErrorHandler {
*/
private final Activity mActivity;
+ private Dialog mDialog;
+
/**
* Create a new Modal Dialog handler for the specified activity and error code. The
* specified activity may be used to launch the dialog via
@@ -141,19 +143,25 @@ public abstract class UserRecoverableErrorHandler {
/**
* Displays the dialog in a modal manner using
- * {@link GoogleApiAvailability#showErrorDialog(int, Activity, int)}.
+ * {@link GoogleApiAvailability#getErrorDialog(Activity, int, int)}.
* @param context the context in which the error was encountered
* @param errorCode the error code from Google Play Services
*/
@Override
protected final void handle(final Context context, final int errorCode) {
- final Dialog dialog = GoogleApiAvailability.getInstance().getErrorDialog(
+ mDialog = GoogleApiAvailability.getInstance().getErrorDialog(
mActivity, errorCode, NO_RESPONSE_REQUIRED);
- if (dialog != null) {
+ if (mDialog != null) {
// This can happen if |errorCode| is ConnectionResult.SERVICE_INVALID.
- dialog.show();
+ mDialog.show();
}
sErrorHandlerActionHistogramSample.record(ERROR_HANDLER_ACTION_MODAL_DIALOG);
}
+
+ public void cancelDialog() {
+ if (mDialog != null) {
+ mDialog.cancel();
+ }
+ }
}
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698