DevTools: fix exception in anchor icon decoration

DevTools: fix exception in anchor icon decoration

Since the anchor's text might have been changed via the textContent
assignment, the icon might not be attached.

This patch makes sure icon is attached to the dom before attempting to
remove it.

BUG=672746
R=dgozman

Committed: https://crrev.com/75e3ed0f6a7521437691659d27664576906c604d
Cr-Commit-Position: refs/heads/master@{#437724}

[lushnikov, 2016-12-09 08:54:26]

please, take a look

[lushnikov, 2016-12-09 08:54:30]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 08:54:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 11:40:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 11:40:12]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-12-09 21:41:48]

lgtm, but we should fix the place which sets textContent on a link returned by
Linkifier.

https://codereview.chromium.org/2552883014/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2552883014/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:329: if
(info.icon && info.icon.parentElement)
=== anchor ?

[lushnikov, 2016-12-10 00:40:46]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-12-10 00:41:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-12-10 00:58:45]

https://codereview.chromium.org/2552883014/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2552883014/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:329: if
(info.icon && info.icon.parentElement)
On 2016/12/09 21:41:48, dgozman wrote:
> === anchor ?

I'd keep this as-is; icon should always be either attached to the anchor, or
detached - otherwise we're hiding a programming error!

[commit-bot: I haz the power, 2016-12-10 02:07:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481330446215490, "parent_rev":
"fc8a21408f06870c7b79715ffdba7beb237fcb45", "commit_rev":
"3fe372def2e801ef1f63d03fd811c23aed6fd4ea"}

[commit-bot: I haz the power, 2016-12-10 02:07:47]

Description was changed from

==========
DevTools: fix exception in anchor icon decoration

Since the anchor's text might have been changed via the textContent
assignment, the icon might not be attached.

This patch makes sure icon is attached to the dom before attempting to
remove it.

BUG=672746
R=dgozman
==========

to

==========
DevTools: fix exception in anchor icon decoration

Since the anchor's text might have been changed via the textContent
assignment, the icon might not be attached.

This patch makes sure icon is attached to the dom before attempting to
remove it.

BUG=672746
R=dgozman

Review-Url: https://codereview.chromium.org/2552883014
==========

[commit-bot: I haz the power, 2016-12-10 02:07:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 15:05:22]

Description was changed from

==========
DevTools: fix exception in anchor icon decoration

Since the anchor's text might have been changed via the textContent
assignment, the icon might not be attached.

This patch makes sure icon is attached to the dom before attempting to
remove it.

BUG=672746
R=dgozman

Review-Url: https://codereview.chromium.org/2552883014
==========

to

==========
DevTools: fix exception in anchor icon decoration

Since the anchor's text might have been changed via the textContent
assignment, the icon might not be attached.

This patch makes sure icon is attached to the dom before attempting to
remove it.

BUG=672746
R=dgozman

Committed: https://crrev.com/75e3ed0f6a7521437691659d27664576906c604d
Cr-Commit-Position: refs/heads/master@{#437724}
==========

[commit-bot: I haz the power, 2016-12-12 15:05:23]

Patchset 1 (id:??) landed as
https://crrev.com/75e3ed0f6a7521437691659d27664576906c604d
Cr-Commit-Position: refs/heads/master@{#437724}