third_party/WebKit/Source/devtools/front_end/components/Linkifier.js - Issue 2552883014: DevTools: fix exception in anchor icon decoration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Issue 2552883014: DevTools: fix exception in anchor icon decoration (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

index a2a31523f74a882af3b70cc7d6a0e65fee4b962c..4926fac9712de8b707479812097b27abdee2146e 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

@@ -326,7 +326,7 @@ Components.Linkifier = class {

return;

if (!Components.Linkifier._decorator || !info.uiLocation)

return;

- if (info.icon)

+ if (info.icon && info.icon.parentElement)

dgozman 2016/12/09 21:41:48 === anchor ?

lushnikov 2016/12/10 00:58:45 I'd keep this as-is; icon should always be either

anchor.removeChild(info.icon);

var icon = Components.Linkifier._decorator.linkIcon(info.uiLocation.uiSourceCode);

if (icon) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »