Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2552883006: cros: Remove unused method. (Closed)

Created:
4 years ago by jdufault
Modified:
4 years ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Remove unused permanent screen concept from BaseScreen. BUG=672142 Committed: https://crrev.com/c64a96a44e5fcfdc8eb8b89cdd7e9d88e9dc8866 Cr-Commit-Position: refs/heads/master@{#437017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M chrome/browser/chromeos/login/screens/base_screen.h View 3 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/screens/base_screen.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
jdufault
Achuith, PTAL when you get a chance. This CL is low-priority.
4 years ago (2016-12-07 18:15:57 UTC) #8
achuithb
lgtm
4 years ago (2016-12-07 18:36:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552883006/1
4 years ago (2016-12-07 18:37:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 18:43:19 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-07 18:46:58 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c64a96a44e5fcfdc8eb8b89cdd7e9d88e9dc8866
Cr-Commit-Position: refs/heads/master@{#437017}

Powered by Google App Engine
This is Rietveld 408576698