Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2555783003: cros: Remove unused method (Closed)

Created:
4 years ago by jdufault
Modified:
4 years ago
Reviewers:
achuithb
CC:
chromium-reviews, pam+watch_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Remove unused BaseScreen::PrepareToShow method BUG=672142 Committed: https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f Cr-Commit-Position: refs/heads/master@{#437027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -173 lines) Patch
M chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen_actor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/mock_enrollment_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/app_launch_splash_screen_actor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/base_screen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/device_disabled_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/device_disabled_screen.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/enable_debugging_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/enable_debugging_screen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/enable_debugging_screen_actor.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/eula_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/eula_screen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/eula_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/host_pairing_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/host_pairing_screen.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/kiosk_enable_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/mock_enable_debugging_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/mock_error_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/mock_eula_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/mock_network_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/mock_update_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/mock_wrong_hwid_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_error_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/reset_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/reset_screen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/reset_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/terms_of_service_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/terms_of_service_screen.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/wrong_hwid_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/wrong_hwid_screen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/wrong_hwid_screen_actor.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ui/models/user_board_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
jdufault
Achuith, PTAL when you get the chance; this CL is low priority. None of the ...
4 years ago (2016-12-07 18:17:45 UTC) #8
achuithb
On 2016/12/07 18:17:45, jdufault wrote: > Achuith, PTAL when you get the chance; this CL ...
4 years ago (2016-12-07 18:35:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555783003/1
4 years ago (2016-12-07 19:04:15 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 19:17:12 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-07 19:19:44 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f
Cr-Commit-Position: refs/heads/master@{#437027}

Powered by Google App Engine
This is Rietveld 408576698