Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2275)

Unified Diff: chrome/browser/chromeos/login/screens/base_screen.h

Issue 2552883006: cros: Remove unused method. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/screens/base_screen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/screens/base_screen.h
diff --git a/chrome/browser/chromeos/login/screens/base_screen.h b/chrome/browser/chromeos/login/screens/base_screen.h
index f1701206d43882e6314bb0fb4949cfd6acab5ad4..c64e6c7cbb690ba97c1bcf1951851a0795696290 100644
--- a/chrome/browser/chromeos/login/screens/base_screen.h
+++ b/chrome/browser/chromeos/login/screens/base_screen.h
@@ -25,9 +25,7 @@ class ModelViewChannel;
// Screens are identified by ID, screen and it's JS counterpart must have same
// id.
// Most of the screens will be re-created for each appearance with Initialize()
-// method called just once. However if initialization is too expensive, screen
-// can override result of IsPermanent() method, and do clean-up upon subsequent
-// Initialize() method calls.
+// method called just once.
class BaseScreen {
public:
explicit BaseScreen(BaseScreenDelegate* base_screen_delegate);
@@ -50,8 +48,7 @@ class BaseScreen {
// Called to perform initialization of the screen. UI is guaranteed to exist
// at this point. Screen can alter context, resulting context will be passed
- // to JS. This method will be called once per instance of the Screen object,
- // unless |IsPermanent()| returns |true|.
+ // to JS. This method will be called once per instance of the Screen object.
virtual void Initialize(::login::ScreenContext* context);
// Called when screen appears.
@@ -69,10 +66,6 @@ class BaseScreen {
// displayed.
virtual bool IsStatusAreaDisplayed();
- // If this method returns |true|, screen will not be deleted once we leave it.
- // However, Initialize() might be called several times in this case.
- virtual bool IsPermanent();
-
// Returns the identifier of the screen.
virtual std::string GetID() const;
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/screens/base_screen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698