Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2552783003: Better reporting of ambiguous and "not found" commands in Obs debugger. (Closed)

Created:
4 years ago by turnidge
Modified:
3 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Better reporting of ambiguous and "not found" commands in Obs debugger. Add a missing space in another random file. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/bcb7cfa79e83b17e7913b2366c51eec299a243b4

Patch Set 1 #

Patch Set 2 : code review #

Patch Set 3 : fix tests #

Patch Set 4 : Better reporting of ambiguous and "not found" commands in Obs debugger. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -12 lines) Patch
M runtime/observatory/lib/src/cli/command.dart View 2 chunks +28 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 1 chunk +11 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/sample_buffer_control.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/command_test.dart View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
4 years ago (2016-12-06 01:06:32 UTC) #2
rmacnak
lgtm
4 years ago (2016-12-06 01:35:54 UTC) #3
turnidge
3 years, 10 months ago (2017-01-31 19:31:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
bcb7cfa79e83b17e7913b2366c51eec299a243b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698