Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: runtime/observatory/lib/src/elements/sample_buffer_control.dart

Issue 2552783003: Better reporting of ambiguous and "not found" commands in Obs debugger. (Closed)
Patch Set: Better reporting of ambiguous and "not found" commands in Obs debugger. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:html'; 6 import 'dart:html';
7 import 'package:observatory/models.dart' as M; 7 import 'package:observatory/models.dart' as M;
8 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart'; 8 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
9 import 'package:observatory/src/elements/helpers/tag.dart'; 9 import 'package:observatory/src/elements/helpers/tag.dart';
10 import 'package:observatory/src/elements/helpers/uris.dart'; 10 import 'package:observatory/src/elements/helpers/uris.dart';
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 ..classes = ['statusBox' 'shadow' 'center'] 135 ..classes = ['statusBox' 'shadow' 'center']
136 ..children = [ 136 ..children = [
137 new DivElement() 137 new DivElement()
138 ..children = [ 138 ..children = [
139 new HeadingElement.h1()..text = 'Profiling is disabled', 139 new HeadingElement.h1()..text = 'Profiling is disabled',
140 new BRElement(), 140 new BRElement(),
141 new DivElement() 141 new DivElement()
142 ..innerHtml = 'Perhaps the <b>profile</b> ' 142 ..innerHtml = 'Perhaps the <b>profile</b> '
143 'flag has been disabled for this VM.', 143 'flag has been disabled for this VM.',
144 new BRElement(), 144 new BRElement(),
145 new SpanElement()..text = 'See all', 145 new SpanElement()..text = 'See all ',
146 new AnchorElement(href: Uris.flags())..text = 'vm flags' 146 new AnchorElement(href: Uris.flags())..text = 'vm flags'
147 ] 147 ]
148 ] 148 ]
149 ]; 149 ];
150 } 150 }
151 151
152 List<Element> _createStatusReport() { 152 List<Element> _createStatusReport() {
153 final fetchT = Utils.formatDurationInSeconds(_progress.fetchingTime); 153 final fetchT = Utils.formatDurationInSeconds(_progress.fetchingTime);
154 final loadT = Utils.formatDurationInSeconds(_progress.loadingTime); 154 final loadT = Utils.formatDurationInSeconds(_progress.loadingTime);
155 final sampleCount = _progress.profile.sampleCount; 155 final sampleCount = _progress.profile.sampleCount;
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 } 248 }
249 throw new Exception('Unknown tagToString'); 249 throw new Exception('Unknown tagToString');
250 } 250 }
251 251
252 SampleBufferControlChangedElement _toEvent(_) { 252 SampleBufferControlChangedElement _toEvent(_) {
253 return new SampleBufferControlChangedElement(this); 253 return new SampleBufferControlChangedElement(this);
254 } 254 }
255 255
256 void _triggerModeChange(e) => _onTagChange.add(e); 256 void _triggerModeChange(e) => _onTagChange.add(e);
257 } 257 }
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/elements/debugger.dart ('k') | runtime/observatory/tests/service/command_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698