Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: runtime/observatory/tests/service/command_test.dart

Issue 2552783003: Better reporting of ambiguous and "not found" commands in Obs debugger. (Closed)
Patch Set: Better reporting of ambiguous and "not found" commands in Obs debugger. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/sample_buffer_control.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/command_test.dart
diff --git a/runtime/observatory/tests/service/command_test.dart b/runtime/observatory/tests/service/command_test.dart
index 8792d872731009e16066741b0dec1ba73ffbc957..90f9d6730e9e8cd8e910fc6bf210c7bcff30881f 100644
--- a/runtime/observatory/tests/service/command_test.dart
+++ b/runtime/observatory/tests/service/command_test.dart
@@ -185,7 +185,7 @@ void testCommandRunNotFound() {
RootCommand cmd = new RootCommand([new TestCommand(out, 'alpha', [])]);
cmd.runCommand('goose').catchError(expectAsync((e) {
- expect(e, equals('No such command'));
+ expect(e.toString(), equals("No such command: 'goose'"));
}));
}
@@ -196,7 +196,8 @@ void testCommandRunAmbiguous() {
new TestCommand(out, 'ankle', [])]);
cmd.runCommand('a 55').catchError(expectAsync((e) {
- expect(e, equals('Ambiguous command'));
+ expect(e.toString(),
+ equals("Command 'a 55' is ambiguous: [alpha, ankle]"));
out.clear();
cmd.runCommand('ankl 55').then(expectAsync((_) {
expect(out.toString(), equals('executing ankle([55])\n'));
« no previous file with comments | « runtime/observatory/lib/src/elements/sample_buffer_control.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698