Remove redundant methods for reloading DataReductionProxyConfig

Remove redundant methods for reloading DataReductionProxyConfig

Currently, there are two ways of updating the configurator in
DataReductionProxyConfig: UpdateConfigurator() and ReloadConfig().
This CL combines them into a single method. Methods that are only
exposed for testing are suffixed with ForTesting() to remove
confusion.

Also, remove some other unreachable code, and a test which is
duplicate of other test.

BUG=476386
Committed: https://crrev.com/f4102ab21954dc43a7ea34797c3e588c919cac2b
Cr-Commit-Position: refs/heads/master@{#436650}

[tbansal1, 2016-12-06 03:53:39]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 03:53:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 05:01:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 05:01:01]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2016-12-06 05:48:32]

Description was changed from

==========
DRP more cleanup

BUG=
==========

to

==========
DRP more cleanup

Currently, there are two ways of updating the configurator: UpdateConfigurator()
and ReloadConfig(). This CL combines them into a
single method. Methods that are only exposed for testing are suffixed
with ForTesting() to remove confusion.

Also, remove some other unreachable code, and a test which is duplicate of other
test.

BUG=
==========

[tbansal1, 2016-12-06 05:48:49]

Description was changed from

==========
DRP more cleanup

Currently, there are two ways of updating the configurator: UpdateConfigurator()
and ReloadConfig(). This CL combines them into a
single method. Methods that are only exposed for testing are suffixed
with ForTesting() to remove confusion.

Also, remove some other unreachable code, and a test which is duplicate of other
test.

BUG=
==========

to

==========
DRP more cleanup

Currently, there are two ways of updating the configurator: 
UpdateConfigurator() and ReloadConfig(). This CL combines them into a
single method. Methods that are only exposed for testing are suffixed
with ForTesting() to remove confusion.

Also, remove some other unreachable code, and a test which is 
duplicate of other test.

BUG=
==========

[tbansal1, 2016-12-06 05:56:23]

Description was changed from

==========
DRP more cleanup

Currently, there are two ways of updating the configurator: 
UpdateConfigurator() and ReloadConfig(). This CL combines them into a
single method. Methods that are only exposed for testing are suffixed
with ForTesting() to remove confusion.

Also, remove some other unreachable code, and a test which is 
duplicate of other test.

BUG=
==========

to

==========
Remove redundant methods for reloading DataReductionProxyConfig

Currently, there are two ways of updating the configurator in
DataReductionProxyConfig: UpdateConfigurator() and ReloadConfig(). 
This CL combines them into a single method. Methods that are only exposed for
testing are suffixed with ForTesting() to remove 
confusion.

Also, remove some other unreachable code, and a test which is 
duplicate of other test.

BUG=
==========

[tbansal1, 2016-12-06 05:56:35]

Description was changed from

==========
Remove redundant methods for reloading DataReductionProxyConfig

Currently, there are two ways of updating the configurator in
DataReductionProxyConfig: UpdateConfigurator() and ReloadConfig(). 
This CL combines them into a single method. Methods that are only exposed for
testing are suffixed with ForTesting() to remove 
confusion.

Also, remove some other unreachable code, and a test which is 
duplicate of other test.

BUG=
==========

to

==========
Remove redundant methods for reloading DataReductionProxyConfig

Currently, there are two ways of updating the configurator in
DataReductionProxyConfig: UpdateConfigurator() and ReloadConfig(). 
This CL combines them into a single method. Methods that are only 
exposed for testing are suffixed with ForTesting() to remove 
confusion.

Also, remove some other unreachable code, and a test which is 
duplicate of other test.

BUG=
==========

[tbansal1, 2016-12-06 17:22:43]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2016-12-06 17:22:44]

ryansturm: ptal. Thanks.

https://codereview.chromium.org/2552623004/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
(left):

https://codereview.chromium.org/2552623004/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc:198:
TEST_F(DataReductionProxyConfigTest, TestUpdateConfigurator) {
Removed this test since it is testing the correctness of ReloadConfig() which is
same as what TestOnIPAddressChanged checks.

[RyanSturm, 2016-12-06 18:03:57]

lgtm

[tbansal1, 2016-12-06 18:07:14]

Description was changed from

==========
Remove redundant methods for reloading DataReductionProxyConfig

Currently, there are two ways of updating the configurator in
DataReductionProxyConfig: UpdateConfigurator() and ReloadConfig(). 
This CL combines them into a single method. Methods that are only 
exposed for testing are suffixed with ForTesting() to remove 
confusion.

Also, remove some other unreachable code, and a test which is 
duplicate of other test.

BUG=
==========

to

==========
Remove redundant methods for reloading DataReductionProxyConfig

Currently, there are two ways of updating the configurator in
DataReductionProxyConfig: UpdateConfigurator() and ReloadConfig(). 
This CL combines them into a single method. Methods that are only 
exposed for testing are suffixed with ForTesting() to remove 
confusion.

Also, remove some other unreachable code, and a test which is 
duplicate of other test.

BUG=476386
==========

[tbansal1, 2016-12-06 18:08:21]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2016-12-06 18:09:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 18:17:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481047701494950, "parent_rev":
"d11dee83c90d4881935fbe3f27fd7755da482718", "commit_rev":
"4fd9d74a598f288a3195d4f3ce57506b6ed78d15"}

[commit-bot: I haz the power, 2016-12-06 18:18:15]

Description was changed from

==========
Remove redundant methods for reloading DataReductionProxyConfig

Currently, there are two ways of updating the configurator in
DataReductionProxyConfig: UpdateConfigurator() and ReloadConfig(). 
This CL combines them into a single method. Methods that are only 
exposed for testing are suffixed with ForTesting() to remove 
confusion.

Also, remove some other unreachable code, and a test which is 
duplicate of other test.

BUG=476386
==========

to

==========
Remove redundant methods for reloading DataReductionProxyConfig

Currently, there are two ways of updating the configurator in
DataReductionProxyConfig: UpdateConfigurator() and ReloadConfig(). 
This CL combines them into a single method. Methods that are only 
exposed for testing are suffixed with ForTesting() to remove 
confusion.

Also, remove some other unreachable code, and a test which is 
duplicate of other test.

BUG=476386
==========

[commit-bot: I haz the power, 2016-12-06 18:18:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-06 18:20:39]

Description was changed from

==========
Remove redundant methods for reloading DataReductionProxyConfig

Currently, there are two ways of updating the configurator in
DataReductionProxyConfig: UpdateConfigurator() and ReloadConfig(). 
This CL combines them into a single method. Methods that are only 
exposed for testing are suffixed with ForTesting() to remove 
confusion.

Also, remove some other unreachable code, and a test which is 
duplicate of other test.

BUG=476386
==========

to

==========
Remove redundant methods for reloading DataReductionProxyConfig

Currently, there are two ways of updating the configurator in
DataReductionProxyConfig: UpdateConfigurator() and ReloadConfig().
This CL combines them into a single method. Methods that are only
exposed for testing are suffixed with ForTesting() to remove
confusion.

Also, remove some other unreachable code, and a test which is
duplicate of other test.

BUG=476386

Committed: https://crrev.com/f4102ab21954dc43a7ea34797c3e588c919cac2b
Cr-Commit-Position: refs/heads/master@{#436650}
==========

[commit-bot: I haz the power, 2016-12-06 18:20:40]

Patchset 1 (id:??) landed as
https://crrev.com/f4102ab21954dc43a7ea34797c3e588c919cac2b
Cr-Commit-Position: refs/heads/master@{#436650}