Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

Issue 2552623004: Remove redundant methods for reloading DataReductionProxyConfig (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
index b029fd2c0656ed16199355fa48d1091d68bfb598..52566c0d2b2c30addc3a1e8f0d50f2d458f30ff8 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
@@ -46,8 +46,8 @@ class DataReductionProxySettingsTest
bool expected_restricted,
bool expected_fallback_restricted) {
test_context_->SetDataReductionProxyEnabled(initially_enabled);
- test_context_->config()->SetStateForTest(initially_enabled,
- request_succeeded);
+ test_context_->config()->UpdateConfigForTesting(initially_enabled,
+ request_succeeded);
ExpectSetProxyPrefs(expected_enabled, false);
settings_->MaybeActivateDataReductionProxy(false);
test_context_->RunUntilIdle();
@@ -63,7 +63,7 @@ class DataReductionProxySettingsTest
TEST_F(DataReductionProxySettingsTest, TestIsProxyEnabledOrManaged) {
InitPrefMembers();
// The proxy is disabled initially.
- test_context_->config()->SetStateForTest(false, true);
+ test_context_->config()->UpdateConfigForTesting(false, true);
EXPECT_FALSE(settings_->IsDataReductionProxyEnabled());
EXPECT_FALSE(settings_->UpdateDataSavings(std::string(), 0, 0));
@@ -85,7 +85,7 @@ TEST_F(DataReductionProxySettingsTest, TestIsProxyEnabledOrManaged) {
TEST_F(DataReductionProxySettingsTest, TestCanUseDataReductionProxy) {
InitPrefMembers();
// The proxy is disabled initially.
- test_context_->config()->SetStateForTest(false, true);
+ test_context_->config()->UpdateConfigForTesting(false, true);
GURL http_gurl("http://url.com/");
EXPECT_FALSE(settings_->CanUseDataReductionProxy(http_gurl));
@@ -248,7 +248,7 @@ TEST(DataReductionProxySettingsStandaloneTest, TestOnProxyEnabledPrefChange) {
.Build();
// The proxy is enabled initially.
- drp_test_context->config()->SetStateForTest(true, true);
+ drp_test_context->config()->UpdateConfigForTesting(true, true);
drp_test_context->InitSettings();
MockDataReductionProxyService* mock_service =

Powered by Google App Engine
This is Rietveld 408576698