Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h

Issue 2552623004: Remove redundant methods for reloading DataReductionProxyConfig (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
index 2eacf0c877927e3875c8ebd848ad72b37141aafc..38442c8f4036ad8b4b4f06dadd60e16022e4d146 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
@@ -211,17 +211,13 @@ class DataReductionProxyConfig
virtual base::TimeTicks GetTicksNow() const;
+ // Updates the Data Reduction Proxy configurator with the current config.
+ void UpdateConfigForTesting(bool enabled, bool restricted);
+
private:
- friend class DataReductionProxyConfigTest;
friend class MockDataReductionProxyConfig;
friend class TestDataReductionProxyConfig;
FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest,
- TestGetDataReductionProxies);
- FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest,
- TestOnIPAddressChanged);
- FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest,
- TestOnIPAddressChanged_SecureProxyDisabledByDefault);
- FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest,
TestSetProxyConfigsHoldback);
FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest,
AreProxiesBypassed);
@@ -246,9 +242,6 @@ class DataReductionProxyConfig
// NetworkChangeNotifier::IPAddressObserver:
void OnIPAddressChanged() override;
- // Updates the Data Reduction Proxy configurator with the current config.
- virtual void UpdateConfigurator(bool enabled, bool restricted);
-
// Populates the parameters for the Lo-Fi field trial if the session is part
// of either Lo-Fi enabled or Lo-Fi control field trial group.
void PopulateAutoLoFiParams();

Powered by Google App Engine
This is Rietveld 408576698