Issue 2552543002: [tools/perf] Fix benchmark smoke tests to not set story_set.stories directly

Issue 2552543002: [tools/perf] Fix benchmark smoke tests to not set story_set.stories directly (Closed)

Created:
4 years ago by nednguyen

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, telemetry-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[tools/perf] Fix benchmark smoke tests to not set story_set.stories directly Without this fix, catapult roll is blocked (https://codereview.chromium.org/2547293002) because CL https://codereview.chromium.org/2153513002/ changes story_set.stories to be a property. BUG=https://github.com/catapult-project/catapult/issues/2429 TBR=eakuefner@chromium.org Committed: https://crrev.com/1b019f5fd30810ea754f51a4ccd0025234e1fa6c Cr-Commit-Position: refs/heads/master@{#436175}

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	tools/perf/benchmarks/benchmark_smoke_unittest.py	View		1 chunk	+4 lines, -3 lines	0 comments	Download
	M	tools/perf/benchmarks/system_health_smoke_test.py	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Total messages: 8 (5 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552543002/1

4 years ago (2016-12-03 17:34:36 UTC) #3

commit-bot: I haz the power

4 years ago (2016-12-03 21:14:44 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1b019f5fd30810ea754f51a4ccd0025234e1fa6c
Cr-Commit-Position: refs/heads/master@{#436175}