Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: tools/perf/benchmarks/benchmark_smoke_unittest.py

Issue 2552543002: [tools/perf] Fix benchmark smoke tests to not set story_set.stories directly (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/system_health_smoke_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/benchmark_smoke_unittest.py
diff --git a/tools/perf/benchmarks/benchmark_smoke_unittest.py b/tools/perf/benchmarks/benchmark_smoke_unittest.py
index e0a5767827603392be32545c62a54b0417a4442c..f236444027d3a423a421ba5b126df77a3bbb9107 100644
--- a/tools/perf/benchmarks/benchmark_smoke_unittest.py
+++ b/tools/perf/benchmarks/benchmark_smoke_unittest.py
@@ -53,9 +53,10 @@ def SmokeTestGenerator(benchmark):
def CreateStorySet(self, options):
# pylint: disable=super-on-old-class
story_set = super(SinglePageBenchmark, self).CreateStorySet(options)
- for story in story_set.stories:
- story_set.stories = [story]
- break
+ # Only smoke test the first story since smoke testing everything takes
+ # too long.
+ for s in story_set.stories[1:]:
+ story_set.RemoveStory(s)
return story_set
# Set the benchmark's default arguments.
« no previous file with comments | « no previous file | tools/perf/benchmarks/system_health_smoke_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698