Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2552543002: [tools/perf] Fix benchmark smoke tests to not set story_set.stories directly (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/benchmark_smoke_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/system_health_smoke_test.py
diff --git a/tools/perf/benchmarks/system_health_smoke_test.py b/tools/perf/benchmarks/system_health_smoke_test.py
index 74026c97acf82726e66fd24637cf7449beeb9192..2f7d31f00ad5741b5a9a48f32f8db2524adebe07 100644
--- a/tools/perf/benchmarks/system_health_smoke_test.py
+++ b/tools/perf/benchmarks/system_health_smoke_test.py
@@ -70,8 +70,11 @@ def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
def CreateStorySet(self, options):
# pylint: disable=super-on-old-class
story_set = super(SinglePageBenchmark, self).CreateStorySet(options)
- assert story_to_smoke_test in story_set.stories
- story_set.stories = [story_to_smoke_test]
+ stories_to_remove = [s for s in story_set.stories if s !=
+ story_to_smoke_test]
+ for s in stories_to_remove:
+ story_set.RemoveStory(s)
+ assert story_set.stories
return story_set
options = GenerateBenchmarkOptions(benchmark_class)
« no previous file with comments | « tools/perf/benchmarks/benchmark_smoke_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698