Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp

Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest. (Closed)
Patch Set: resolve code review comments from foolip Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
diff --git a/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp b/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
index 888ff33c472f57338ed6b49b8e558044ff95650d..3f273a3d173b9137b31e9e5f92ce1317d9f11e4e 100644
--- a/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
+++ b/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
@@ -14,6 +14,7 @@
#include "platform/testing/URLTestHelpers.h"
#include "platform/weborigin/KURL.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "wtf/Vector.h"
#include <v8.h>
namespace blink {
@@ -21,13 +22,16 @@ namespace {
TEST(PresentationAvailabilityTest, NoPageVisibilityChangeAfterDetach) {
V8TestingScope scope;
- const KURL url = URLTestHelpers::toKURL("https://example.com");
+ WTF::Vector<KURL> urls;
+ urls.append(URLTestHelpers::toKURL("https://example.com"));
+ urls.append(URLTestHelpers::toKURL("https://another.com"));
+
Persistent<PresentationAvailabilityProperty> resolver =
new PresentationAvailabilityProperty(
scope.getExecutionContext(), nullptr,
PresentationAvailabilityProperty::Ready);
Persistent<PresentationAvailability> availability =
- PresentationAvailability::take(resolver, url, false);
+ PresentationAvailability::take(resolver, urls, false);
// These two calls should not crash.
scope.frame().detach(FrameDetachType::Remove);

Powered by Google App Engine
This is Rietveld 408576698