third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp - Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest.

Side by Side Diff: third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp

Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest. (Closed)

Patch Set: resolve code review comments from foolip Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/presentation/presentation-start.html ('K') | « third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationConnection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "modules/presentation/PresentationAvailability.h"	5 #include "modules/presentation/PresentationAvailability.h"

6	6

7 #include "bindings/core/v8/ScriptPromiseResolver.h"	7 #include "bindings/core/v8/ScriptPromiseResolver.h"

8 #include "bindings/core/v8/V8BindingForTesting.h"	8 #include "bindings/core/v8/V8BindingForTesting.h"

9 #include "core/dom/DOMException.h"	9 #include "core/dom/DOMException.h"

10 #include "core/frame/LocalFrame.h"	10 #include "core/frame/LocalFrame.h"

11 #include "core/page/Page.h"	11 #include "core/page/Page.h"

12 #include "core/testing/DummyPageHolder.h"	12 #include "core/testing/DummyPageHolder.h"

13 #include "modules/presentation/PresentationRequest.h"	13 #include "modules/presentation/PresentationRequest.h"

14 #include "platform/testing/URLTestHelpers.h"	14 #include "platform/testing/URLTestHelpers.h"

15 #include "platform/weborigin/KURL.h"	15 #include "platform/weborigin/KURL.h"

16 #include "testing/gtest/include/gtest/gtest.h"	16 #include "testing/gtest/include/gtest/gtest.h"

	17 #include "wtf/Vector.h"

17 #include <v8.h>	18 #include <v8.h>

18	19

19 namespace blink {	20 namespace blink {

20 namespace {	21 namespace {

21	22

22 TEST(PresentationAvailabilityTest, NoPageVisibilityChangeAfterDetach) {	23 TEST(PresentationAvailabilityTest, NoPageVisibilityChangeAfterDetach) {

23 V8TestingScope scope;	24 V8TestingScope scope;

24 const KURL url = URLTestHelpers::toKURL("https://example.com");	25 WTF::Vector<KURL> urls;

	26 urls.append(URLTestHelpers::toKURL("https://example.com"));

	27 urls.append(URLTestHelpers::toKURL("https://another.com"));

	28

25 Persistent<PresentationAvailabilityProperty> resolver =	29 Persistent<PresentationAvailabilityProperty> resolver =

26 new PresentationAvailabilityProperty(	30 new PresentationAvailabilityProperty(

27 scope.getExecutionContext(), nullptr,	31 scope.getExecutionContext(), nullptr,

28 PresentationAvailabilityProperty::Ready);	32 PresentationAvailabilityProperty::Ready);

29 Persistent<PresentationAvailability> availability =	33 Persistent<PresentationAvailability> availability =

30 PresentationAvailability::take(resolver, url, false);	34 PresentationAvailability::take(resolver, urls, false);

31	35

32 // These two calls should not crash.	36 // These two calls should not crash.

33 scope.frame().detach(FrameDetachType::Remove);	37 scope.frame().detach(FrameDetachType::Remove);

34 scope.page().setVisibilityState(PageVisibilityStateHidden, false);	38 scope.page().setVisibilityState(PageVisibilityStateHidden, false);

35 }	39 }

36	40

37 } // anonymous namespace	41 } // anonymous namespace

38 } // namespace blink	42 } // namespace blink

OLD	NEW