third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp - Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp

Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest. (Closed)

Patch Set: resolve code review comments from foolip Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/presentation/presentation-start.html ('K') | « third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.h ('k') | third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp b/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp

index cdb336da813b0579a75ad4bd026bc8756f7c80c7..77e8e2e9c87ee5936a09e22bcc1f35aa23207ff9 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp

@@ -15,8 +15,8 @@ namespace blink {

PresentationAvailabilityCallbacks::PresentationAvailabilityCallbacks(

PresentationAvailabilityProperty* resolver,

- const KURL& url)

- : m_resolver(resolver), m_url(url) {

+ const Vector<KURL>& urls)

+ : m_resolver(resolver), m_urls(urls) {

ASSERT(m_resolver);

}

@@ -27,7 +27,7 @@ void PresentationAvailabilityCallbacks::onSuccess(bool value) {

m_resolver->getExecutionContext()->isContextDestroyed())

return;

m_resolver->resolve(

- PresentationAvailability::take(m_resolver.get(), m_url, value));

+ PresentationAvailability::take(m_resolver.get(), m_urls, value));

}

void PresentationAvailabilityCallbacks::onError(