Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2551473002: Correctly re-collect active style for html imports. (Closed)

Created:
1 year, 7 months ago by rune
Modified:
1 year, 7 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, webcomponents-bugzilla_chromium.org, tfarina, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly re-collect active style for html imports. - Need to re-collect active stylesheets when inserting already cached import documents. - Missing markDocumentDirty() when inserting import documents. - Added test for missing coverage of the need for marking for re- collection from HTMLImportChild::ownerInserted(). The fact that we need to recollect sheets in the document scope and recalculate style for the whole document is not a perf regression, this is how it used to be before considering the async stylesheet update with ruleset invalidations, but ideally we would like to do better. It's unlikely a common use case as html imports are typically loaded in head as script and rendering blocking. R=meade@chromium.org BUG=567021 Committed: https://crrev.com/2e3e5148b008e60b37270fec3f6099914550a310 Cr-Commit-Position: refs/heads/master@{#436238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/fast/html/imports/import-add-child-to-change-order-of-dup-css.html View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 2 chunks +12 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/imports/LinkImport.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
rune
1 year, 7 months ago (2016-12-02 14:10:42 UTC) #3
meade_UTC10
lgtm
1 year, 7 months ago (2016-12-05 03:05:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551473002/1
1 year, 7 months ago (2016-12-05 05:46:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
1 year, 7 months ago (2016-12-05 07:22:36 UTC) #10
commit-bot: I haz the power
1 year, 7 months ago (2016-12-05 07:24:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e3e5148b008e60b37270fec3f6099914550a310
Cr-Commit-Position: refs/heads/master@{#436238}

Powered by Google App Engine
This is Rietveld 408576698