Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2547883002: Schedule layout tree update for dirty tree scopes. (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10, nainar
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Schedule layout tree update for dirty tree scopes. In preparation for async stylesheet update, schedule a layout tree update when marking tree scopes dirty for active style sheets. This is necessary to trigger a beginFrame which will in turn call updateActiveStyle as part of the lifecycle update. R=meade@chromium.org BUG=567021 Committed: https://crrev.com/27d26e3a00a4e59b6b52071dcd177fcb45f91a97 Cr-Commit-Position: refs/heads/master@{#436248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (10 generated)
rune
ptal
4 years ago (2016-12-02 17:40:10 UTC) #3
meade_UTC10
lgtm
4 years ago (2016-12-05 03:07:09 UTC) #6
nainar
lgtm
4 years ago (2016-12-05 03:08:53 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2551473002 Patch 1). Please resolve the dependency and ...
4 years ago (2016-12-05 05:46:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547883002/1
4 years ago (2016-12-05 08:08:12 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 09:38:52 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-05 09:40:46 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27d26e3a00a4e59b6b52071dcd177fcb45f91a97
Cr-Commit-Position: refs/heads/master@{#436248}

Powered by Google App Engine
This is Rietveld 408576698