Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp

Issue 2551473002: Correctly re-collect active style for html imports. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 HTMLImportChild::HTMLImportChild(const KURL& url, 47 HTMLImportChild::HTMLImportChild(const KURL& url,
48 HTMLImportLoader* loader, 48 HTMLImportLoader* loader,
49 SyncMode sync) 49 SyncMode sync)
50 : HTMLImport(sync), m_url(url), m_loader(loader), m_client(nullptr) {} 50 : HTMLImport(sync), m_url(url), m_loader(loader), m_client(nullptr) {}
51 51
52 HTMLImportChild::~HTMLImportChild() {} 52 HTMLImportChild::~HTMLImportChild() {}
53 53
54 void HTMLImportChild::ownerInserted() { 54 void HTMLImportChild::ownerInserted() {
55 if (!m_loader->isDone()) 55 if (!m_loader->isDone())
56 return; 56 return;
57 root()->document()->styleEngine().resolverChanged(FullStyleUpdate); 57 document()->styleEngine().htmlImportAddedOrRemoved();
58 // TODO(rune@opera.com): resolverChanged() can be removed once stylesheet
59 // updates are async. https://crbug.com/567021
60 root()->document()->styleEngine().resolverChanged(AnalyzedStyleUpdate);
58 } 61 }
59 62
60 void HTMLImportChild::didShareLoader() { 63 void HTMLImportChild::didShareLoader() {
61 createCustomElementMicrotaskStepIfNeeded(); 64 createCustomElementMicrotaskStepIfNeeded();
62 stateWillChange(); 65 stateWillChange();
63 } 66 }
64 67
65 void HTMLImportChild::didStartLoading() { 68 void HTMLImportChild::didStartLoading() {
66 createCustomElementMicrotaskStepIfNeeded(); 69 createCustomElementMicrotaskStepIfNeeded();
67 } 70 }
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 #endif 189 #endif
187 190
188 DEFINE_TRACE(HTMLImportChild) { 191 DEFINE_TRACE(HTMLImportChild) {
189 visitor->trace(m_customElementMicrotaskStep); 192 visitor->trace(m_customElementMicrotaskStep);
190 visitor->trace(m_loader); 193 visitor->trace(m_loader);
191 visitor->trace(m_client); 194 visitor->trace(m_client);
192 HTMLImport::trace(visitor); 195 HTMLImport::trace(visitor);
193 } 196 }
194 197
195 } // namespace blink 198 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/StyleEngine.cpp ('k') | third_party/WebKit/Source/core/html/imports/LinkImport.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698