Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2550973002: Revert "win: /utf-8 for all code" (Closed)

Created:
4 years ago by aleksandar.stojiljkovic
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "win: /utf-8 for all code" This reverts commit a53f3c3734ad9ee4322f6a9a60eede7f6b04530f. Original CL: https://codereview.chromium.org/2543743002 Reason for revert: Compilation issue on master.tryserver.chromium.win:win_optional_gpu_tests_rel Failing [1] task on the bot: FAILED: obj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj ninja -t msvc -e environment.x86 -- E:\b\c\cipd\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj.rsp /c ../../third_party/deqp/src/modules/gles3/performance/es3pBufferDataUploadTests.cpp /Foobj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj /Fd"obj/third_party/angle/src/tests/angle_deqp_libgles3_cc.pdb" e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): error C2220: warning treated as error - no 'object' file generated e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): warning C4828: The file contains a character starting at offset 0x3714f that is illegal in the current source character set (codepage 65001). e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings [1] https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/5729/steps/compile%20%28without%20patch%29/logs/stdio BUG=454858, 637203, 671021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true NOTREECHECKS=true TBR=scottmg@chromium.org, dpranke@chromium.org Committed: https://crrev.com/373af458aa9ab8f6f8650da115209c74d14f5dea Cr-Commit-Position: refs/heads/master@{#436195}

Patch Set 1 : Revert "win: /utf-8 for all code" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M build/config/compiler/BUILD.gn View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
aleksandar.stojiljkovic
Already verified it fixing the bot in the tryrun here: https://codereview.chromium.org/2442273002/#ps720001
4 years ago (2016-12-04 13:44:59 UTC) #5
Ken Russell (switch to Gerrit)
LGTM. Just discovered this independently and filed http://crbug.com/671021 about it.
4 years ago (2016-12-04 16:41:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550973002/20001
4 years ago (2016-12-04 16:41:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550973002/20001
4 years ago (2016-12-04 16:45:06 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-04 16:47:43 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/373af458aa9ab8f6f8650da115209c74d14f5dea Cr-Commit-Position: refs/heads/master@{#436195}
4 years ago (2016-12-04 16:49:38 UTC) #19
Dirk Pranke
4 years ago (2016-12-04 22:03:52 UTC) #20
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698