Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2543743002:
win: /utf-8 for all code (Closed)
|
Created:
4 years ago by scottmg Modified:
4 years ago Reviewers:
Dirk Pranke CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionwin: /utf-8 for all code
Previously enabled for chromium_code, can now be turned on everywhere.
BUG=454858, 637203, 671021
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f
Cr-Commit-Position: refs/heads/master@{#436189}
Committed: https://crrev.com/663994ebf90ac57f5cc56a9639a16e29aee1ff2b
Cr-Commit-Position: refs/heads/master@{#438029}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase for reland, no change, other deps rolled #Messages
Total messages: 34 (23 generated)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Description was changed from ========== win: /utf-8 for non-chromium_code BUG=454858,637203 ========== to ========== win: /utf-8 for non-chromium_code BUG=454858,637203 ==========
scottmg@chromium.org changed reviewers: + dpranke@chromium.org
Description was changed from ========== win: /utf-8 for non-chromium_code BUG=454858,637203 ========== to ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480824635063640,
"parent_rev": "ea7b611a351cf32c89b7e534da502c71eed3a55a", "commit_rev":
"f33a187039dfee6f2926b999f783594c394981b3"}
Message was sent while issue was closed.
Description was changed from ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203 ========== to ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203 ========== to ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203 Committed: https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f Cr-Commit-Position: refs/heads/master@{#436189} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f Cr-Commit-Position: refs/heads/master@{#436189}
Message was sent while issue was closed.
On 2016/12/04 06:53:47, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as > https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f > Cr-Commit-Position: refs/heads/master@{#436189} A revert is here: https://codereview.chromium.org/2550973002/
Message was sent while issue was closed.
Description was changed from ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203 Committed: https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f Cr-Commit-Position: refs/heads/master@{#436189} ========== to ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203, 671021 Committed: https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f Cr-Commit-Position: refs/heads/master@{#436189} ==========
Message was sent while issue was closed.
Description was changed from ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203, 671021 Committed: https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f Cr-Commit-Position: refs/heads/master@{#436189} ========== to ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203, 671021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f Cr-Commit-Position: refs/heads/master@{#436189} ==========
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by scottmg@chromium.org
The CQ bit was checked by scottmg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2543743002/#ps40001 (title: "rebase for reland, no change, other deps rolled")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481594037471630,
"parent_rev": "e5b177bb8563d593744f74fbd3433acfd8553343", "commit_rev":
"53cde229a24fcb9c7fc6132de820919cee020e3b"}
Message was sent while issue was closed.
Description was changed from ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203, 671021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f Cr-Commit-Position: refs/heads/master@{#436189} ========== to ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203, 671021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f Cr-Commit-Position: refs/heads/master@{#436189} Review-Url: https://codereview.chromium.org/2543743002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203, 671021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f Cr-Commit-Position: refs/heads/master@{#436189} Review-Url: https://codereview.chromium.org/2543743002 ========== to ========== win: /utf-8 for all code Previously enabled for chromium_code, can now be turned on everywhere. BUG=454858,637203, 671021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f Cr-Commit-Position: refs/heads/master@{#436189} Committed: https://crrev.com/663994ebf90ac57f5cc56a9639a16e29aee1ff2b Cr-Commit-Position: refs/heads/master@{#438029} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/663994ebf90ac57f5cc56a9639a16e29aee1ff2b Cr-Commit-Position: refs/heads/master@{#438029} |
