Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2550413004: Remove Ash shelf dimmer. (Closed)

Created:
4 years ago by Evan Stade
Modified:
4 years ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Ash shelf dimmer. BUG=671718 Committed: https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8 Cr-Commit-Position: refs/heads/master@{#437621}

Patch Set 1 #

Total comments: 4

Patch Set 2 : jamescook review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -753 lines) Patch
M ash/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ash/aura/wm_shelf_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/aura/wm_shelf_aura.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/common/shelf/app_list_button.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/shelf/overflow_button.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/shelf/shelf_layout_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/common/shelf/shelf_view.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/shelf/shelf_view.cc View 1 3 chunks +0 lines, -11 lines 0 comments Download
M ash/common/shelf/shelf_widget.h View 3 chunks +0 lines, -18 lines 0 comments Download
M ash/common/shelf/shelf_widget.cc View 11 chunks +2 lines, -114 lines 0 comments Download
D ash/common/shelf/wm_dimmer_view.h View 1 chunk +0 lines, -37 lines 0 comments Download
M ash/common/shelf/wm_shelf.h View 2 chunks +0 lines, -12 lines 0 comments Download
M ash/common/shelf/wm_shelf.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ash/common/system/tray/tray_background_view.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 2 chunks +0 lines, -3 lines 0 comments Download
D ash/resources/default_100_percent/common/shelf/shelf_dimming.png View 1 Binary file 0 comments Download
D ash/resources/default_100_percent/common/shelf/status_icon_background_onblack_normal.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_onblack_normal.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/shelf/shelf_dimming.png View 1 Binary file 0 comments Download
D ash/resources/default_200_percent/common/shelf/status_icon_background_onblack_normal.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_onblack_normal.png View Binary file 0 comments Download
D ash/shelf/dimmer_view.h View 1 chunk +0 lines, -115 lines 0 comments Download
D ash/shelf/dimmer_view.cc View 1 chunk +0 lines, -182 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 9 chunks +0 lines, -210 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Evan Stade
4 years ago (2016-12-07 22:17:35 UTC) #4
James Cook
LGTM with nits https://codereview.chromium.org/2550413004/diff/1/ash/common/shelf/shelf_widget.cc File ash/common/shelf/shelf_widget.cc (left): https://codereview.chromium.org/2550413004/diff/1/ash/common/shelf/shelf_widget.cc#oldcode396 ash/common/shelf/shelf_widget.cc:396: shelf_view_->SchedulePaintForAllButtons(); I think this is the ...
4 years ago (2016-12-08 01:26:44 UTC) #7
James Cook
And thanks for cleaning this up!
4 years ago (2016-12-08 01:26:59 UTC) #8
Evan Stade
both good catches, thanks. https://codereview.chromium.org/2550413004/diff/1/ash/common/shelf/shelf_widget.cc File ash/common/shelf/shelf_widget.cc (left): https://codereview.chromium.org/2550413004/diff/1/ash/common/shelf/shelf_widget.cc#oldcode396 ash/common/shelf/shelf_widget.cc:396: shelf_view_->SchedulePaintForAllButtons(); On 2016/12/08 01:26:43, James ...
4 years ago (2016-12-08 17:13:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550413004/20001
4 years ago (2016-12-08 17:20:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82462)
4 years ago (2016-12-08 18:50:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550413004/20001
4 years ago (2016-12-09 18:01:50 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 20:26:16 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-12 14:37:19 UTC) #21
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8
Cr-Commit-Position: refs/heads/master@{#437621}

Powered by Google App Engine
This is Rietveld 408576698