Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: ash/common/shelf/shelf_view.cc

Issue 2550413004: Remove Ash shelf dimmer. (Closed)
Patch Set: jamescook review Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/shelf/shelf_view.h ('k') | ash/common/shelf/shelf_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/shelf_view.cc
diff --git a/ash/common/shelf/shelf_view.cc b/ash/common/shelf/shelf_view.cc
index 74cc4bc1d4becf8fbfdfc9ca51045e65afdcc672..0ea75695608d2069e0336d29dac2007222b8c4ea 100644
--- a/ash/common/shelf/shelf_view.cc
+++ b/ash/common/shelf/shelf_view.cc
@@ -433,15 +433,6 @@ void ShelfView::OnShelfAlignmentChanged() {
app_list_button->SchedulePaint();
}
-void ShelfView::SchedulePaintForAllButtons() {
- for (int i = 0; i < view_model_->view_size(); ++i) {
- if (i >= first_visible_index_ && i <= last_visible_index_)
- view_model_->view_at(i)->SchedulePaint();
- }
- if (overflow_button_ && overflow_button_->visible())
- overflow_button_->SchedulePaint();
-}
-
gfx::Rect ShelfView::GetIdealBoundsOfItemIcon(ShelfID id) {
int index = model_->ItemIndexByID(id);
if (index == -1)
@@ -1843,7 +1834,6 @@ void ShelfView::ShowMenu(std::unique_ptr<ui::MenuModel> menu_model,
}
}
- shelf_widget_->ForceUndimming(true);
// NOTE: if you convert to HAS_MNEMONICS be sure to update menu building code.
launcher_menu_runner_->RunMenuAt(source->GetWidget(), nullptr, anchor,
menu_alignment, source_type);
@@ -1851,7 +1841,6 @@ void ShelfView::ShowMenu(std::unique_ptr<ui::MenuModel> menu_model,
void ShelfView::OnMenuClosed(views::InkDrop* ink_drop) {
context_menu_id_ = 0;
- shelf_widget_->ForceUndimming(false);
// Hide the hide overflow bubble after showing a context menu for its items.
if (owner_overflow_bubble_)
« no previous file with comments | « ash/common/shelf/shelf_view.h ('k') | ash/common/shelf/shelf_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698