Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc

Issue 2550373005: Make WebTaskRunner ThreadSafeRefCounted (Closed)
Patch Set: +DISALLOW_COPY_AND_ASSIGN for win build fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
index 13f2f6be0293345f8c3af0243124eb0d3c5e77bc..cdd3ee287597c10482eefbef26342e498ba9223f 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
@@ -102,7 +102,7 @@ void WebFrameSchedulerImpl::setCrossOrigin(bool cross_origin) {
UpdateTimerThrottling(was_throttled);
}
-blink::WebTaskRunner* WebFrameSchedulerImpl::loadingTaskRunner() {
+RefPtr<blink::WebTaskRunner> WebFrameSchedulerImpl::loadingTaskRunner() {
DCHECK(parent_web_view_scheduler_);
if (!loading_web_task_runner_) {
loading_task_queue_ = renderer_scheduler_->NewLoadingTaskRunner(
@@ -111,12 +111,12 @@ blink::WebTaskRunner* WebFrameSchedulerImpl::loadingTaskRunner() {
loading_queue_enabled_voter_ =
loading_task_queue_->CreateQueueEnabledVoter();
loading_queue_enabled_voter_->SetQueueEnabled(!frame_suspended_);
- loading_web_task_runner_.reset(new WebTaskRunnerImpl(loading_task_queue_));
+ loading_web_task_runner_ = WebTaskRunnerImpl::create(loading_task_queue_);
}
- return loading_web_task_runner_.get();
+ return loading_web_task_runner_;
}
-blink::WebTaskRunner* WebFrameSchedulerImpl::timerTaskRunner() {
+RefPtr<blink::WebTaskRunner> WebFrameSchedulerImpl::timerTaskRunner() {
DCHECK(parent_web_view_scheduler_);
if (!timer_web_task_runner_) {
timer_task_queue_ = renderer_scheduler_->NewTimerTaskRunner(
@@ -136,21 +136,21 @@ blink::WebTaskRunner* WebFrameSchedulerImpl::timerTaskRunner() {
renderer_scheduler_->task_queue_throttler()->IncreaseThrottleRefCount(
timer_task_queue_.get());
}
- timer_web_task_runner_.reset(new WebTaskRunnerImpl(timer_task_queue_));
+ timer_web_task_runner_ = WebTaskRunnerImpl::create(timer_task_queue_);
}
- return timer_web_task_runner_.get();
+ return timer_web_task_runner_;
}
-blink::WebTaskRunner* WebFrameSchedulerImpl::unthrottledTaskRunner() {
+RefPtr<blink::WebTaskRunner> WebFrameSchedulerImpl::unthrottledTaskRunner() {
DCHECK(parent_web_view_scheduler_);
if (!unthrottled_web_task_runner_) {
unthrottled_task_queue_ = renderer_scheduler_->NewUnthrottledTaskRunner(
TaskQueue::QueueType::FRAME_UNTHROTTLED);
unthrottled_task_queue_->SetBlameContext(blame_context_);
- unthrottled_web_task_runner_.reset(
- new WebTaskRunnerImpl(unthrottled_task_queue_));
+ unthrottled_web_task_runner_ =
+ WebTaskRunnerImpl::create(unthrottled_task_queue_);
}
- return unthrottled_web_task_runner_.get();
+ return unthrottled_web_task_runner_;
}
blink::WebViewScheduler* WebFrameSchedulerImpl::webViewScheduler() {

Powered by Google App Engine
This is Rietveld 408576698