third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h - Issue 2550373005: Make WebTaskRunner ThreadSafeRefCounted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h

Issue 2550373005: Make WebTaskRunner ThreadSafeRefCounted (Closed)

Patch Set: +DISALLOW_COPY_AND_ASSIGN for win build fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc ('k') | third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h

diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h

index 9e3a050734e2a5ca5edd307eeb8c9b110315b3cb..1ced35e71be31b3ec645b2b32a84a37e6ed9d57c 100644

--- a/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h

+++ b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h

@@ -42,9 +42,9 @@ class WebFrameSchedulerImpl : public WebFrameScheduler {

void setPageVisible(bool page_visible) override;

void setSuspended(bool frame_suspended) override;

void setCrossOrigin(bool cross_origin) override;

- WebTaskRunner* loadingTaskRunner() override;

- WebTaskRunner* timerTaskRunner() override;

- WebTaskRunner* unthrottledTaskRunner() override;

+ RefPtr<WebTaskRunner> loadingTaskRunner() override;

+ RefPtr<WebTaskRunner> timerTaskRunner() override;

+ RefPtr<WebTaskRunner> unthrottledTaskRunner() override;

WebViewScheduler* webViewScheduler() override;

void didStartLoading(unsigned long identifier) override;

void didStopLoading(unsigned long identifier) override;

@@ -67,9 +67,9 @@ class WebFrameSchedulerImpl : public WebFrameScheduler {

scoped_refptr<TaskQueue> unthrottled_task_queue_;

std::unique_ptr<TaskQueue::QueueEnabledVoter> loading_queue_enabled_voter_;

std::unique_ptr<TaskQueue::QueueEnabledVoter> timer_queue_enabled_voter_;

- std::unique_ptr<WebTaskRunnerImpl> loading_web_task_runner_;

- std::unique_ptr<WebTaskRunnerImpl> timer_web_task_runner_;

- std::unique_ptr<WebTaskRunnerImpl> unthrottled_web_task_runner_;

+ RefPtr<WebTaskRunnerImpl> loading_web_task_runner_;

+ RefPtr<WebTaskRunnerImpl> timer_web_task_runner_;

+ RefPtr<WebTaskRunnerImpl> unthrottled_web_task_runner_;

RendererSchedulerImpl* renderer_scheduler_; // NOT OWNED

WebViewSchedulerImpl* parent_web_view_scheduler_; // NOT OWNED

base::trace_event::BlameContext* blame_context_; // NOT OWNED