Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3141)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc

Issue 2550373005: Make WebTaskRunner ThreadSafeRefCounted (Closed)
Patch Set: +DISALLOW_COPY_AND_ASSIGN for win build fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
index dcb5dabf71ac728d67f96b66cbb9aefa68519175..60eb0e60d39eda418e13f7ef65a878dcce247267 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
@@ -58,19 +58,22 @@ class WebFrameSchedulerImplTest : public testing::Test {
namespace {
-void runRepeatingTask(WebTaskRunner* task_runner, int* run_count);
+void runRepeatingTask(RefPtr<WebTaskRunner> task_runner, int* run_count);
std::unique_ptr<WTF::Closure> makeRepeatingTask(
- blink::WebTaskRunner* task_runner,
+ RefPtr<blink::WebTaskRunner> task_runner,
int* run_count) {
- return WTF::bind(&runRepeatingTask, WTF::unretained(task_runner),
+ return WTF::bind(&runRepeatingTask, WTF::passed(std::move(task_runner)),
WTF::unretained(run_count));
}
-void runRepeatingTask(WebTaskRunner* task_runner, int* run_count) {
+void runRepeatingTask(RefPtr<WebTaskRunner> task_runner, int* run_count) {
++*run_count;
- task_runner->postDelayedTask(BLINK_FROM_HERE,
- makeRepeatingTask(task_runner, run_count), 1.0);
+
+ WebTaskRunner* task_runner_ptr = task_runner.get();
+ task_runner_ptr->postDelayedTask(
+ BLINK_FROM_HERE, makeRepeatingTask(std::move(task_runner), run_count),
+ 1.0);
}
void IncrementCounter(int* counter) {

Powered by Google App Engine
This is Rietveld 408576698