Refactor code to clear last signed-in user.

Refactor code to clear last signed-in user.

BUG=353359
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267117

[acleung1, 2014-04-28 22:57:23]

Hi Tommy:

The existing code seems to only wipe last user when a managed dominated is
signed out.

I created a new function in SigninManger to do that and we can share that in
both code path.

WTYT?

[nyquist, 2014-04-29 17:18:47]

lgtm

https://codereview.chromium.org/255013004/diff/1/chrome/browser/android/signi...
File chrome/browser/android/signin/signin_manager_android.cc (right):

https://codereview.chromium.org/255013004/diff/1/chrome/browser/android/signi...
chrome/browser/android/signin/signin_manager_android.cc:210: void
SigninManagerAndroid::ClearLastSignedInUser(JNIEnv* env, jobject obj) {
I was under impression that the style guide said no function overloading? Could
you just verify that this is fine, and else just append "Java" or something to
the name?

[acleung1, 2014-04-29 21:45:54]

https://codereview.chromium.org/255013004/diff/1/chrome/browser/android/signi...
File chrome/browser/android/signin/signin_manager_android.cc (right):

https://codereview.chromium.org/255013004/diff/1/chrome/browser/android/signi...
chrome/browser/android/signin/signin_manager_android.cc:210: void
SigninManagerAndroid::ClearLastSignedInUser(JNIEnv* env, jobject obj) {
On 2014/04/29 17:18:47, nyquist wrote:
> I was under impression that the style guide said no function overloading?
Could
> you just verify that this is fine, and else just append "Java" or something to
> the name?

I can't seem to find that in the style guide. The Google one said overload only
if it is obvious to the read which is which.

Operator overload is discouraged. May be that's what you were thinking about?

[acleung1, 2014-04-29 21:45:58]

The CQ bit was checked by acleung@chromium.org

[commit-bot: I haz the power, 2014-04-29 21:48:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acleung@chromium.org/255013004/1

[nyquist, 2014-04-29 22:14:53]

https://codereview.chromium.org/255013004/diff/1/chrome/browser/android/signi...
File chrome/browser/android/signin/signin_manager_android.cc (right):

https://codereview.chromium.org/255013004/diff/1/chrome/browser/android/signi...
chrome/browser/android/signin/signin_manager_android.cc:210: void
SigninManagerAndroid::ClearLastSignedInUser(JNIEnv* env, jobject obj) {
On 2014/04/29 21:45:54, acleung1 wrote:
> On 2014/04/29 17:18:47, nyquist wrote:
> > I was under impression that the style guide said no function overloading?
> Could
> > you just verify that this is fine, and else just append "Java" or something
to
> > the name?
> 
> I can't seem to find that in the style guide. The Google one said overload
only
> if it is obvious to the read which is which.
> 
> Operator overload is discouraged. May be that's what you were thinking about?

Ah. That might be it. Or that I was reading the "only if it is obvious" as "have
a very good reason". And I consider this a good reason, and it's clear that one
is JNI-based. Thanks for checking!

[commit-bot: I haz the power, 2014-04-29 22:23:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 22:23:51]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium

[acleung1, 2014-04-30 00:45:56]

The CQ bit was checked by acleung@chromium.org

[commit-bot: I haz the power, 2014-04-30 00:47:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acleung@chromium.org/255013004/1

[commit-bot: I haz the power, 2014-04-30 07:21:48]

Change committed as 267117