Refactor code to clear last signed-in user.

chrome/browser/android/signin/signin_manager_android.cc

Index: chrome/browser/android/signin/signin_manager_android.cc
diff --git a/chrome/browser/android/signin/signin_manager_android.cc b/chrome/browser/android/signin/signin_manager_android.cc
index 43af5fad4c0a5d77c680351fdcd4e2353f87a9c8..2fac5f7e11c2911ad21369038af928aa0ee49c7b 100644
--- a/chrome/browser/android/signin/signin_manager_android.cc
+++ b/chrome/browser/android/signin/signin_manager_android.cc
@@ -201,12 +201,20 @@ void SigninManagerAndroid::OnBrowsingDataRemoverDone() {
 
   // All the Profile data has been wiped. Clear the last signed in username as
   // well, so that the next signin doesn't trigger the acount change dialog.
-  profile_->GetPrefs()->ClearPref(prefs::kGoogleServicesLastUsername);
+  ClearLastSignedInUser();
 
   Java_SigninManager_onProfileDataWiped(base::android::AttachCurrentThread(),
                                         java_signin_manager_.obj());
 }
 
+void SigninManagerAndroid::ClearLastSignedInUser(JNIEnv* env, jobject obj) {

[nyquist, 2014/04/29 17:18:47]

I was under impression that the style guide said no function overloading? Could
you just verify that this is fine, and else just append "Java" or something to
the name?

[acleung1, 2014/04/29 21:45:54]

I can't seem to find that in the style guide. The Google one said overload only
if it is obvious to the read which is which.

Operator overload is discouraged. May be that's what you were thinking about?

[nyquist, 2014/04/29 22:14:54]

Ah. That might be it. Or that I was reading the "only if it is obvious" as "have
a very good reason". And I consider this a good reason, and it's clear that one
is JNI-based. Thanks for checking!

+  ClearLastSignedInUser();
+}
+
+void SigninManagerAndroid::ClearLastSignedInUser() {
+  profile_->GetPrefs()->ClearPref(prefs::kGoogleServicesLastUsername);
+}
+
 void SigninManagerAndroid::MergeSessionCompleted(
     const std::string& account_id,
     const GoogleServiceAuthError& error) {