Refactor code to clear last signed-in user.

chrome/browser/android/signin/signin_manager_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/signin/signin_manager_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 183 matching lines @@
 }
 
 #endif
 
 void SigninManagerAndroid::OnBrowsingDataRemoverDone() {
   BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile_);
   model->RemoveAll();
 
   // All the Profile data has been wiped. Clear the last signed in username as
   // well, so that the next signin doesn't trigger the acount change dialog.
-  profile_->GetPrefs()->ClearPref(prefs::kGoogleServicesLastUsername);
+  ClearLastSignedInUser();
 
   Java_SigninManager_onProfileDataWiped(base::android::AttachCurrentThread(),
                                         java_signin_manager_.obj());
 }
 
+void SigninManagerAndroid::ClearLastSignedInUser(JNIEnv* env, jobject obj) {

[nyquist, 2014/04/29 17:18:47]

I was under impression that the style guide said no function overloading? Could
you just verify that this is fine, and else just append "Java" or something to
the name?

[acleung1, 2014/04/29 21:45:54]

I can't seem to find that in the style guide. The Google one said overload only
if it is obvious to the read which is which.

Operator overload is discouraged. May be that's what you were thinking about?

[nyquist, 2014/04/29 22:14:54]

Ah. That might be it. Or that I was reading the "only if it is obvious" as "have
a very good reason". And I consider this a good reason, and it's clear that one
is JNI-based. Thanks for checking!

+  ClearLastSignedInUser();
+}
+
+void SigninManagerAndroid::ClearLastSignedInUser() {
+  profile_->GetPrefs()->ClearPref(prefs::kGoogleServicesLastUsername);
+}
+
 void SigninManagerAndroid::MergeSessionCompleted(
     const std::string& account_id,
     const GoogleServiceAuthError& error) {
   merge_session_helper_->RemoveObserver(this);
   merge_session_helper_.reset();
 }
 
 void SigninManagerAndroid::LogInSignedInUser(JNIEnv* env, jobject obj) {
   SigninManagerBase* signin_manager =
       SigninManagerFactory::GetForProfile(profile_);
@@ skipping 41 matching lines @@
 }
 
 static jboolean IsNewProfileManagementEnabled(JNIEnv* env, jclass clazz) {
   return switches::IsNewProfileManagement();
 }
 
 // static
 bool SigninManagerAndroid::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }