Remove RefPtr<ScriptState> from PerformanceObserver

Remove RefPtr<ScriptState> from PerformanceObserver

RefPtr<ScriptState> stored in DOM objects has a risk of leaking ScriptStates
to unexpected worlds. We should explicitly pass in ScriptState when we need it.

BUG=669812
Committed: https://crrev.com/abaeeda1ff88d9c71936f120e5c37c4a88c302da
Cr-Commit-Position: refs/heads/master@{#435916}

[haraken, 2016-12-02 06:54:33]

haraken@chromium.org changed reviewers:
+ yukishiino@chromium.org

[haraken, 2016-12-02 06:54:34]

PTAL

[Yuki, 2016-12-02 07:07:02]

LGTM % a comment.

https://codereview.chromium.org/2549673004/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
(right):

https://codereview.chromium.org/2549673004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp:58:
currentExecutionContext(info.GetIsolate()), performance, callback);
Why don't you use scriptState->getExecutionContext()?

In the constructor (i.e. constructorCustom), the current realm must equal to the
relevant realm of the receiver object, so your code should be okay.  However, I
don't want to mix them.

We've already using scriptState for PerformanceObserverCallback::create() on
line 54-55, so using scriptState->getExecutionContext() is consistent, I think.

[haraken, 2016-12-02 07:18:57]

On 2016/12/02 07:07:02, Yuki wrote:
> LGTM % a comment.
> 
>
https://codereview.chromium.org/2549673004/diff/20001/third_party/WebKit/Sour...
> File
>
third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
> (right):
> 
>
https://codereview.chromium.org/2549673004/diff/20001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp:58:
> currentExecutionContext(info.GetIsolate()), performance, callback);
> Why don't you use scriptState->getExecutionContext()?
> 
> In the constructor (i.e. constructorCustom), the current realm must equal to
the
> relevant realm of the receiver object, so your code should be okay.  However,
I
> don't want to mix them.
> 
> We've already using scriptState for PerformanceObserverCallback::create() on
> line 54-55, so using scriptState->getExecutionContext() is consistent, I
think.

I just wanted to follow the auto-generated code.
[ConstructorCallWith=ExecutionContext] generates
currentExecutionContext(info.GetIsolate()) ?

[Yuki, 2016-12-02 07:41:35]

On 2016/12/02 07:18:57, haraken wrote:
> On 2016/12/02 07:07:02, Yuki wrote:
> > LGTM % a comment.
> > 
> >
>
https://codereview.chromium.org/2549673004/diff/20001/third_party/WebKit/Sour...
> > File
> >
>
third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
> > (right):
> > 
> >
>
https://codereview.chromium.org/2549673004/diff/20001/third_party/WebKit/Sour...
> >
>
third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp:58:
> > currentExecutionContext(info.GetIsolate()), performance, callback);
> > Why don't you use scriptState->getExecutionContext()?
> > 
> > In the constructor (i.e. constructorCustom), the current realm must equal to
> the
> > relevant realm of the receiver object, so your code should be okay. 
However,
> I
> > don't want to mix them.
> > 
> > We've already using scriptState for PerformanceObserverCallback::create() on
> > line 54-55, so using scriptState->getExecutionContext() is consistent, I
> think.
> 
> I just wanted to follow the auto-generated code.
> [ConstructorCallWith=ExecutionContext] generates
> currentExecutionContext(info.GetIsolate()) ?

Oops, then LGTM.
I need to fix it.

[haraken, 2016-12-02 07:42:58]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-02 07:43:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 11:38:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480664578590260,
"parent_rev": "bea49eec3617dd50ca3732206952fe480a1d12ba", "commit_rev":
"324a0d59141aa8fdf7812d891ddb56dc548a6743"}

[commit-bot: I haz the power, 2016-12-02 11:39:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 11:41:41]

Description was changed from

==========
Remove RefPtr<ScriptState> from PerformanceObserver

RefPtr<ScriptState> stored in DOM objects has a risk of leaking ScriptStates
to unexpected worlds. We should explicitly pass in ScriptState when we need it.

BUG=669812
==========

to

==========
Remove RefPtr<ScriptState> from PerformanceObserver

RefPtr<ScriptState> stored in DOM objects has a risk of leaking ScriptStates
to unexpected worlds. We should explicitly pass in ScriptState when we need it.

BUG=669812

Committed: https://crrev.com/abaeeda1ff88d9c71936f120e5c37c4a88c302da
Cr-Commit-Position: refs/heads/master@{#435916}
==========

[commit-bot: I haz the power, 2016-12-02 11:41:42]

Patchset 2 (id:??) landed as
https://crrev.com/abaeeda1ff88d9c71936f120e5c37c4a88c302da
Cr-Commit-Position: refs/heads/master@{#435916}