Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

Issue 2549673004: Remove RefPtr<ScriptState> from PerformanceObserver (Closed)
Patch Set: temp Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ExecutionContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
index 11d65aafbdcbe4a66acf0ca522ec966feed79bbc..c3e8deacc3036225d608e15d9f320864826865fa 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
@@ -54,8 +54,8 @@ void V8PerformanceObserver::constructorCustom(
PerformanceObserverCallback* callback =
PerformanceObserverCallback::create(scriptState, v8Callback);
- PerformanceObserver* observer =
- PerformanceObserver::create(scriptState, performance, callback);
+ PerformanceObserver* observer = PerformanceObserver::create(
+ currentExecutionContext(info.GetIsolate()), performance, callback);
Yuki 2016/12/02 07:07:01 Why don't you use scriptState->getExecutionContext
// TODO(bashi): Don't set private property (and remove this custom
// constructor) when we can call setWrapperReference() correctly.
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ExecutionContext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698