Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: third_party/WebKit/Source/core/dom/ExecutionContext.h

Issue 2549673004: Remove RefPtr<ScriptState> from PerformanceObserver (Closed)
Patch Set: temp Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ExecutionContext.h
diff --git a/third_party/WebKit/Source/core/dom/ExecutionContext.h b/third_party/WebKit/Source/core/dom/ExecutionContext.h
index e0c259d9cbd13bd5de48740cf3955d391676208d..12349c47c791ce45d8464374ab228098ec7563e7 100644
--- a/third_party/WebKit/Source/core/dom/ExecutionContext.h
+++ b/third_party/WebKit/Source/core/dom/ExecutionContext.h
@@ -127,6 +127,10 @@ class CORE_EXPORT ExecutionContext : public ContextLifecycleNotifier,
void suspendScheduledTasks();
void resumeScheduledTasks();
+
+ // TODO(haraken): Remove these methods by making the customers inherit from
+ // ActiveDOMObject. ActiveDOMObject is a standard way to observe context
+ // suspension/resumption.
virtual bool tasksNeedSuspension() { return false; }
virtual void tasksWereSuspended() {}
virtual void tasksWereResumed() {}

Powered by Google App Engine
This is Rietveld 408576698