Fix TestBrowserThread destruction order in CrOS tests.

Fix TestBrowserThread destruction order in CrOS tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916
Committed: https://crrev.com/d4277b0cc41219c665fd3133ad72ce9b8039161b
Cr-Commit-Position: refs/heads/master@{#436154}

[gab, 2016-12-02 19:22:00]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 19:22:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-12-02 19:23:50]

gab@chromium.org changed reviewers:
+ oshima@chromium.org

[gab, 2016-12-02 19:23:51]

Easy review :-)

@oshima for chromeos/
@sque for leak_detector/
@isherman for easy_unlock_*

Thanks!
Gab

https://codereview.chromium.org/2549623006/diff/1/chrome/browser/metrics/leak...
File chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc
(right):

https://codereview.chromium.org/2549623006/diff/1/chrome/browser/metrics/leak...
chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc:62:
base::LazyInstance<TestLeakDetectorController>::Leaky g_instance =
Needs to be leaky or its destructor runs after the TestBrowserThreadBundle above
is destroyed and something in it DCHECKs CurrentlyOn(UI).

[gab, 2016-12-02 19:26:07]

Description was changed from

==========
Fix TestBrowserThread destruction order in CrOS tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916
==========

to

==========
Fix TestBrowserThread destruction order in CrOS tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916
==========

[gab, 2016-12-02 19:26:07]

gab@chromium.org changed reviewers:
+ isherman@chromium.org, sque@chromium.org

[gab, 2016-12-02 19:26:27]

On 2016/12/02 19:23:51, gab wrote:
> Easy review :-)
> 
> @oshima for chromeos/
> @sque for leak_detector/
> @isherman for easy_unlock_*

Oops, actually +sque/isherman :-)

> 
> Thanks!
> Gab
> 
>
https://codereview.chromium.org/2549623006/diff/1/chrome/browser/metrics/leak...
> File chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/2549623006/diff/1/chrome/browser/metrics/leak...
> chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc:62:
> base::LazyInstance<TestLeakDetectorController>::Leaky g_instance =
> Needs to be leaky or its destructor runs after the TestBrowserThreadBundle
above
> is destroyed and something in it DCHECKs CurrentlyOn(UI).

[Simon Que, 2016-12-02 19:28:23]

lgtm for leak_detector_controller_unittest.cc

[commit-bot: I haz the power, 2016-12-02 19:47:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 19:47:15]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-12-02 20:18:12]

lgtm with a nit

https://codereview.chromium.org/2549623006/diff/1/chrome/browser/metrics/leak...
File chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc
(right):

https://codereview.chromium.org/2549623006/diff/1/chrome/browser/metrics/leak...
chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc:62:
base::LazyInstance<TestLeakDetectorController>::Leaky g_instance =
On 2016/12/02 19:23:51, gab wrote:
> Needs to be leaky or its destructor runs after the TestBrowserThreadBundle
above
> is destroyed and something in it DCHECKs CurrentlyOn(UI).

can you update the comment above?

[oshima, 2016-12-02 20:18:14]

lgtm with a nit

[Ilya Sherman, 2016-12-02 23:53:35]

easy_unlock lgtm

[gab, 2016-12-03 03:02:27]

Thanks, done.

https://codereview.chromium.org/2549623006/diff/1/chrome/browser/metrics/leak...
File chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc
(right):

https://codereview.chromium.org/2549623006/diff/1/chrome/browser/metrics/leak...
chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc:62:
base::LazyInstance<TestLeakDetectorController>::Leaky g_instance =
On 2016/12/02 20:18:12, oshima wrote:
> On 2016/12/02 19:23:51, gab wrote:
> > Needs to be leaky or its destructor runs after the TestBrowserThreadBundle
> above
> > is destroyed and something in it DCHECKs CurrentlyOn(UI).
> 
> can you update the comment above?

Done.

[gab, 2016-12-03 03:02:50]

The CQ bit was checked by gab@chromium.org

[gab, 2016-12-03 03:02:50]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
isherman@chromium.org, sque@chromium.org
Link to the patchset: https://codereview.chromium.org/2549623006/#ps20001
(title: "+comment on Leaky")

[commit-bot: I haz the power, 2016-12-03 03:03:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 03:15:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480734170109330,
"parent_rev": "126f424fe18803f4f7250476b81258ed0665f761", "commit_rev":
"c6be16164db1c22233645d10bd60e4129e5586e0"}

[commit-bot: I haz the power, 2016-12-03 03:15:53]

Description was changed from

==========
Fix TestBrowserThread destruction order in CrOS tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916
==========

to

==========
Fix TestBrowserThread destruction order in CrOS tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916
==========

[commit-bot: I haz the power, 2016-12-03 03:15:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-03 03:17:28]

Description was changed from

==========
Fix TestBrowserThread destruction order in CrOS tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916
==========

to

==========
Fix TestBrowserThread destruction order in CrOS tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916

Committed: https://crrev.com/d4277b0cc41219c665fd3133ad72ce9b8039161b
Cr-Commit-Position: refs/heads/master@{#436154}
==========

[commit-bot: I haz the power, 2016-12-03 03:17:29]

Patchset 2 (id:??) landed as
https://crrev.com/d4277b0cc41219c665fd3133ad72ce9b8039161b
Cr-Commit-Position: refs/heads/master@{#436154}