chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc - Issue 2549623006: Fix TestBrowserThread destruction order in CrOS tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc

Issue 2549623006: Fix TestBrowserThread destruction order in CrOS tests. (Closed)

Patch Set: +comment on Leaky Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/net/wake_on_wifi_manager_unittest.cc ('k') | chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc

diff --git a/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc b/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc

index a7ffe0bf188aa84ab6a481a63c219eb0122eccce..a1bde6844bb5ec49e779cecfd1fe2270551b27bf 100644

--- a/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc

+++ b/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc

@@ -312,10 +312,12 @@ class NetworkConfigurationUpdaterTest : public testing::Test {

std::unique_ptr<PolicyServiceImpl> policy_service_;

FakeUser fake_user_;

+ // Must outlive |profile_|.

+ content::TestBrowserThreadBundle thread_bundle_;

TestingProfile profile_;

std::unique_ptr<NetworkConfigurationUpdater> network_configuration_updater_;

- content::TestBrowserThreadBundle thread_bundle_;

};

TEST_F(NetworkConfigurationUpdaterTest, CellularAllowRoaming) {