Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5033)

Unified Diff: chrome/browser/chromeos/hats/hats_finch_helper_unittest.cc

Issue 2549623006: Fix TestBrowserThread destruction order in CrOS tests. (Closed)
Patch Set: +comment on Leaky Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/hats/hats_finch_helper_unittest.cc
diff --git a/chrome/browser/chromeos/hats/hats_finch_helper_unittest.cc b/chrome/browser/chromeos/hats/hats_finch_helper_unittest.cc
index fa32979dda89aebabbc6cdead2895dd22de1558f..c342a01fcdac80af62f0f3f82dbfdbe3a26e86f6 100644
--- a/chrome/browser/chromeos/hats/hats_finch_helper_unittest.cc
+++ b/chrome/browser/chromeos/hats/hats_finch_helper_unittest.cc
@@ -57,11 +57,15 @@ class HatsFinchHelperTest : public testing::Test {
return params;
}
+ private:
+ // Must outlive |profile_|.
+ content::TestBrowserThreadBundle thread_bundle_;
+
+ protected:
TestingProfile profile_;
private:
variations::testing::VariationParamsManager params_manager_;
- content::TestBrowserThreadBundle thread_bundle_;
base::test::ScopedFeatureList scoped_feature_list_;
DISALLOW_COPY_AND_ASSIGN(HatsFinchHelperTest);

Powered by Google App Engine
This is Rietveld 408576698